Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"If the specific volume does not appear..." label not associated with its input #3884

Closed
3 tasks done
sandbergja opened this issue Dec 6, 2023 · 0 comments · Fixed by #3912
Closed
3 tasks done

"If the specific volume does not appear..." label not associated with its input #3884

sandbergja opened this issue Dec 6, 2023 · 0 comments · Fixed by #3912
Assignees
Labels
accessibility A Web Content Accessibility Guidelines (WCAG) - Level A is the minimum level

Comments

@sandbergja
Copy link
Member

sandbergja commented Dec 6, 2023

Steps to recreate

  1. Go to https://catalog-staging.princeton.edu/catalog/99124728563506421
  2. Press Request button
  3. Run WAVE or axe. Alternatively, use your browser's accessibility inspector in the dev tools to inspect the input with the placeholder "Ex: Volume 2, 1987". Notice that this input does not have an accessible label.

URL

https://catalog-staging.princeton.edu/requests/99124728563506421?aeon=false&mfhd=22727203630006421

Issues

3.3.2 Labels or Instructions

Severity

High, this is a level A issue that could block a user from requesting a specific issue of a journal.

WCAG Conformance level (A, AA, AAA)

Level A

User impact

User may not be able to request a specific issue of a journal.

Recommended fix

Make sure that the input id attribute and label for attribute match.

Acceptance criteria

  • I can confirm that Voice Over in Safari reads the label when I navigate to the input.
  • I have checked that this issue no longer exists, and that I haven't added any further level A or level AA issues with one of the following extensions:
    • axe dev tools
    • Lighthouse
    • Wave
  • Add an accessibility test to this screen that will catch further regressions in this label/input pair.
@sandbergja sandbergja added the accessibility A Web Content Accessibility Guidelines (WCAG) - Level A is the minimum level label Dec 6, 2023
@rladdusaw rladdusaw self-assigned this Dec 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accessibility A Web Content Accessibility Guidelines (WCAG) - Level A is the minimum level
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants