Fixing the Rubocop violations

pulibrary · Mar 30, 2020 · 471945a · 471945a
1 parent 505d8a6
commit 471945a
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 3 deletions.
diff --git a/.rubocop.yml b/.rubocop.yml
@@ -12,6 +12,9 @@ AllCops:
     - 'node_modules/**/*'
     - 'spec/support/**/*'
     - 'tmp/**/*'
+Metrics/AbcSize:
+  Exclude:
+    - 'app/services/tree_navigation_service.rb'
 Metrics/BlockLength:
   Exclude:
     - 'lib/tasks/plantain.rake'
@@ -22,6 +25,7 @@ Metrics/BlockLength:
 Metrics/MethodLength:
   Exclude:
     - 'lib/tasks/plantain.rake'
+    - 'app/services/tree_navigation_service.rb'
 Metrics/ExampleLength:
   Exclude:
     - 'spec/features/traject/ead2_indexing_spec.rb'

diff --git a/app/services/tree_navigation_service.rb b/app/services/tree_navigation_service.rb
@@ -34,18 +34,16 @@ def self.build(solr_document)
 
         parent_document = solr_document.clone
         parent_document["children"] = []
-        component["parents"] = [parent_document]
       else
         # This assumes that the document is being parsed in order
-        parent_document = tree[parent_id]
         tree[parent_id]["children"] = tree[parent_id]["children"] || []
         tree[parent_id]["children"] << component
 
         parent_document = tree[parent_id].clone
         parent_document["children"] = []
         parent_document["parents"] = []
-        component["parents"] = [parent_document]
       end
+      component["parents"] = [parent_document]
       tree[component_id] = component
     end