Fix to use collections instead of manifests

app/decorators/applies_title_from_slug.rb

@@ -7,9 +7,16 @@ def initialize(record, slug)
   end
 
   def save(*args)
-    __getobj__.title = title
     __getobj__.slug = slug
+    __getobj__.title = title
+    return false unless valid?
+    super
+  end
+
+  def valid?(*args)
     super
+    errors.add :slug, "can't be blank" if slug.blank?
+    errors.blank?
   end
 
   private
@@ -19,6 +26,6 @@ def manifest
     end
 
     def title
-      manifest.label
+      manifest.try(:label)
     end
 end

app/queries/external_collections_query.rb

@@ -17,8 +17,8 @@ def initialize(remote_url)
   end
 
   def collection_manifests
-    @collection_manifests ||= manifest_urls.map do |url|
-      CollectionManifest.load(url)
+    @collection_manifests ||= all_manifest.collections.map do |collection|
+      CollectionManifest.new(collection.send(:data))
     end
   end
 
@@ -27,10 +27,4 @@ def collection_manifests
     def all_manifest
       @all_manifest ||= ExternalManifest.load(remote_url)
     end
-
-    def manifest_urls
-      all_manifest.manifests.map do |manifest|
-        manifest['@id']
-      end
-    end
 end

spec/controllers/exhibits_controller_spec.rb

@@ -23,5 +23,20 @@
         expect(last_exhibit.slug).to eq "princeton-best"
       end
     end
+    context "when not given a slug" do
+      let(:params) do
+        {
+          exhibit: {
+            slug: ""
+          }
+        }
+      end
+      it "renders an error" do
+        post :create, params
+
+        expect(response).to render_template "new"
+        expect(assigns["exhibit"].errors.messages[:slug]).to eq ["can't be blank"]
+      end
+    end
   end
 end

spec/models/external_manifest_spec.rb

@@ -5,7 +5,7 @@
     subject { described_class.load(manifest_url) }
     let(:manifest_url) { "https://hydra-dev.princeton.edu/collections/manifest" }
     it "loads up a manifest" do
-      expect(subject.manifests.length).to eql 2
+      expect(subject.collections.length).to eql 2
     end
   end
 end

spec/queries/external_collections_query_spec.rb

@@ -4,7 +4,7 @@
   subject { described_class }
   describe ".all" do
     it "queries plum for all collections" do
-      expect(subject.all.map(&:slug)).to eq ["test-collection-2", "princeton-best"]
+      expect(subject.all.map(&:slug)).to eq ["princeton-best", "test-collection-2"]
     end
   end
 end