Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RIIIF should return a 404 when an image isn't found, not throw an error. #574

Closed
jrgriffiniii opened this issue Apr 15, 2019 — with Honeybadger · 3 comments
Closed
Labels

Comments

Copy link
Contributor

Backtrace

View full backtrace and more info at honeybadger.io

@jrgriffiniii
Copy link
Contributor Author

It doesn't appear to be the case that this could be handled with a proper 404 response without overriding the ImageController for the riiif Gem. Should riiif be still be being accessed within the production environment for DPUL? If so, I can look to address this by submitting a pull request upstream.

@jrgriffiniii jrgriffiniii removed their assignment Apr 29, 2019
@tpendragon tpendragon changed the title [Pomegranate/production] Riiif::ImageNotFoundError: Riiif::ImageNotFoundError RIIIF should return a 404 when an image isn't found, not throw an error. Sep 16, 2019
@tpendragon tpendragon added the bug label Sep 16, 2019
@hackartisan
Copy link
Member

It looks like it does 404 at least at one point.
https://github.com/curationexperts/riiif/blob/9dcd95f06f1dbac49cc5fa6eea6b1bc3f224efb9/app/controllers/riiif/images_controller.rb#L18

It seems difficult to proceed on this issue without the honeybadger trace. I propose we close it, as the underlying problem (shared network drive) has been resolved.

@tpendragon
Copy link
Contributor

Sounds good to me

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants