Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce exhibit-card image size and allow more cards per row on home page #387

Merged
merged 2 commits into from
Jun 22, 2018

Conversation

hackartisan
Copy link
Member

fixes #377

@coveralls
Copy link

coveralls commented Jun 22, 2018

Coverage Status

Coverage remained the same at 100.0% when pulling 41e2445 on issue/377-exhibit-card-flow into 6c32413 on master.

@escowles
Copy link
Member

Can you post screen shots showing the backs of some of the collections with longer descriptions (e.g. scheide and islamicmss?) — it's been a struggle to get those descriptions to fit.

@hackartisan
Copy link
Member Author

@escowles good call; the islamicmss is running down too far. the container width is a bootstrap breakpoint so I was hesitant to adjust that. I could bump the thumbnail size back up and reduce margins? I will mess around.

screen shot 2018-06-22 at 8 54 07 am

@escowles
Copy link
Member

This is beyond my CSS skills — but it occurs to me that the focused card could be bigger and overflow the side of the face-up cards — which could give us more room for the description while keeping the compact display.

@hackartisan
Copy link
Member Author

At that point i might wonder why we wouldn't just use a modal. the whole mechanism is fishy to me, honestly; you can't click on the back of the card unless you can hover on it? seems like an accessibility issue. on mobile it looks like you can tap but i'm not sure whether there are sufficient cues for a screenreading user.

Some UX tickets on this repo would be welcome; ;I believe there are some upstream that would be relevant. e.g. this one tripped me up yesterday even though I clearly already knew about it from the code4lib workshop: projectblacklight/spotlight#1897

@hackartisan
Copy link
Member Author

here's a screenshot of the latest effort
screen shot 2018-06-22 at 10 15 09 am

@escowles escowles merged commit 135283c into master Jun 22, 2018
@escowles escowles deleted the issue/377-exhibit-card-flow branch June 22, 2018 14:35
@escowles escowles removed the review label Jun 22, 2018
@escowles
Copy link
Member

@HackMasterA I agree about the card-flip animation — that's always seemed annoying to me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove blank right column from home
3 participants