Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update header and footer to match orangelight #401

Merged
merged 4 commits into from
Jul 16, 2018

Conversation

hackartisan
Copy link
Member

resolves #287
resolves #378

@hackartisan
Copy link
Member Author

The site title only displays on child pages, to avoid redundancy with the front page masthead

screen shot 2018-07-02 at 2 38 47 pm
screen shot 2018-07-02 at 2 38 58 pm

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 3fa4cff on issue/287-update-header into 5deadf1 on master.

Copy link
Contributor

@jrgriffiniii jrgriffiniii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm getting some issues when the viewport is reduced to 320px on https://dpul-staging.princeton.edu/cotsen within the staging environment using Firefox Quantum release 61.0:

pomegranate_pull_401_0

Please disregard if this is out of scope.

Otherwise on the specified release of Firefox and Google Chrome 67.0.3396.99, this is perfectly responsive 👍

Copy link
Contributor

@jrgriffiniii jrgriffiniii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Testing on Edge 17 using BrowserStack also demonstrated that this is satisfactory.

@hackartisan
Copy link
Member Author

thank you for the thorough testing!

@tpendragon tpendragon merged commit 1f01eff into master Jul 16, 2018
@tpendragon tpendragon deleted the issue/287-update-header branch July 16, 2018 11:53
@tpendragon tpendragon removed the review label Jul 16, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

footer to match catalog / library site New Header CSS
4 participants