Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade Spotlight #601

Merged
merged 12 commits into from
Sep 24, 2019
Merged

Upgrade Spotlight #601

merged 12 commits into from
Sep 24, 2019

Conversation

tpendragon
Copy link
Contributor

Steps for upgrade:

  1. bundle update blacklight-spotlight rails
  2. Install new migrations, follow directions in upgrade notes.
  3. Copy over new versions of overridden views.
  4. Get tests passing.
  5. Fix weird route thing.

@escowles
Copy link
Member

This looks good to me — looks ready to deploy to staging for some manual testing, once that's working.

@tpendragon tpendragon temporarily deployed to staging September 16, 2019 21:20 Inactive
@hackartisan
Copy link
Member

hackartisan commented Sep 17, 2019 •
edited
Loading

Please rebase before deploying for further testing! Needs the nested child solr query fix.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling cc1dd90 on upgrade_spotlight into 60a2f12 on master.

@tpendragon
Copy link
Contributor Author

I tested this on staging and things wouldn't reindex. I just rebased so I could test again later, when Kim doesn't need it.

@tpendragon tpendragon temporarily deployed to staging September 17, 2019 21:13 Inactive
@tpendragon tpendragon temporarily deployed to staging September 18, 2019 18:36 Inactive
@tpendragon
Copy link
Contributor Author

I tested this and things were indexing and displaying fine. Needs confirmation from @kelea99

@tpendragon tpendragon marked this pull request as ready for review September 24, 2019 17:48
@hackartisan hackartisan merged commit 6cbc7b3 into master Sep 24, 2019
@eliotjordan eliotjordan deleted the upgrade_spotlight branch September 24, 2019 18:34
@hackartisan hackartisan mentioned this pull request Aug 10, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hackartisan hackartisan hackartisan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@tpendragon @escowles @hackartisan @coveralls