-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add subtitle to site masthead. #612
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Having the subtitle makes the masthead taller so that going to an exhibit with no subtitle puts the search bar in a different place and feels like an awkward transition. Could we pad when the subtitle is missing?
@HackMasterA If I did that it would look like this: That's preferrable? |
Yeah it's not great. What if we pull the title down when there's no subtitle? Then the title would jump around a bit but I think that would be less disruptive than the whole masthead changing size. Or maybe you have some other idea/s. Should we user test a few things? Ask for more opinions? |
What if we kept a min-height to keep the header the same height, but reduced the space between the subtitle and the search bar? That seems like a reasonable way to tradeoff having the title stay in one place, but not have a ton of extra space when there's no subtitle. |
Closes #573