Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add subtitle to site masthead. #612

Merged
merged 3 commits into from
Sep 18, 2019
Merged

Add subtitle to site masthead. #612

merged 3 commits into from
Sep 18, 2019

Conversation

tpendragon
Copy link
Contributor

@tpendragon tpendragon commented Sep 18, 2019

Closes #573

Screen Shot 2019-09-18 at 11 06 38 AM

Copy link
Member

@hackartisan hackartisan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Having the subtitle makes the masthead taller so that going to an exhibit with no subtitle puts the search bar in a different place and feels like an awkward transition. Could we pad when the subtitle is missing?

@tpendragon
Copy link
Contributor Author

@HackMasterA If I did that it would look like this:

Screen Shot 2019-09-18 at 11 10 38 AM

That's preferrable?

@hackartisan
Copy link
Member

Yeah it's not great. What if we pull the title down when there's no subtitle? Then the title would jump around a bit but I think that would be less disruptive than the whole masthead changing size. Or maybe you have some other idea/s. Should we user test a few things? Ask for more opinions?

@tpendragon tpendragon temporarily deployed to staging September 18, 2019 18:14 Inactive
@escowles
Copy link
Member

What if we kept a min-height to keep the header the same height, but reduced the space between the subtitle and the search bar? That seems like a reasonable way to tradeoff having the title stay in one place, but not have a ton of extra space when there's no subtitle.

@coveralls
Copy link

coveralls commented Sep 18, 2019

Coverage Status

Coverage remained the same at 100.0% when pulling 55f3313 on masthead_subtitle into ad54bc4 on master.

@tpendragon tpendragon temporarily deployed to staging September 18, 2019 18:30 Inactive
@hackartisan hackartisan merged commit 7f3700e into master Sep 18, 2019
@hackartisan hackartisan deleted the masthead_subtitle branch September 18, 2019 18:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

We should display site subtitle
4 participants