Implement Recent Items Widget #616
Conversation
|
Note: This still sorts by timestamp, but sorting by recently modified will require a variety of changes through Pomegranate and Figgy which I'll make some issues for. Created #617, #619, and pulibrary/figgy#3387. |
| @@ -0,0 +1,4 @@ | |||
| <% # container for all documents in index view -%> | |||
There was a problem hiding this comment.
are these names required by the solr document helper? It seems like it would be nice to have them flipped around aka _recent_items_document and _recent_items_index
There was a problem hiding this comment.
Also why can't they live in app/views/spotlight/sir_trevor/blocks/ with the other template?
| @@ -0,0 +1,8 @@ | |||
| <div class="card"> | |||
There was a problem hiding this comment.
So the single item partial is called index but the collection partial is called document? That is confusing :(
There was a problem hiding this comment.
I agree. It was how Spotlight had it set up for auto-looking up partials. Since we're using less of that now I can try to avoid it.
| @@ -0,0 +1,23 @@ | |||
| FactoryBot.define do | |||
| factory :iiif_resource, class: IIIFResource do | |||
|
|
||
| url = "https://hydra-dev.princeton.edu/concern/scanned_resources/1r66j1149/manifest" | ||
| FactoryBot.create(:iiif_resource, url: url, exhibit: exhibit, manifest_fixture: "1r66j1149-expanded.json", source_metadata_identifier: "12345678", spec: self) | ||
| FactoryBot.create(:iiif_resource, url: "https://hydra-dev.princeton.edu/concern/scanned_resources/44558d29f/manifest", exhibit: exhibit, manifest_fixture: "44558d29f.json", spec: self) |
There was a problem hiding this comment.
It's sort of weird having one url defined above and other defined inside the parens. both lines are sort of long and it would be good to be able to see what's being defined; maybe just make them both multi-line?
|
|
||
| before do | ||
| # The view spec is separate from the CatalogController, which has this piece | ||
| # of configuration in Blacklight. So to get paths to resolve, we need this. |
| # Source metadata identifier to stub out | ||
| source_metadata_identifier { nil } | ||
| # Reference to the spec to enable the factory to stub out requests. | ||
| spec { nil } |
There was a problem hiding this comment.
define the stub in the factory, never thought of this; seems handy.
There was a problem hiding this comment.
Yeah, I'm not sure I'm a fan yet, but if we're going to try using more factories it seems like something to fiddle with.
tpendragon
force-pushed
the
recent_items_widget
branch
from
9887ac1
to
602a9a8
Compare
tpendragon
force-pushed
the
recent_items_widget
branch
from
602a9a8
to
fe1b45f
Compare
Closes #597
This PR looks like the following:
There's an earlier commit that has a more ordered set up, but I personally liked LAE-style cards better. Here's what the earlier set up looked like: