Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support indexing Recording IIIF 3 manifests. #732

Merged
merged 1 commit into from
Feb 10, 2020
Merged

Support indexing Recording IIIF 3 manifests. #732

merged 1 commit into from
Feb 10, 2020

Conversation

tpendragon
Copy link
Contributor

Closes #663

@coveralls
Copy link

coveralls commented Feb 10, 2020 •
edited

Coverage Status

Coverage remained the same at 100.0% when pulling 451f1ff on 663-recordings-sync into 37b96e7 on master.

jrgriffiniii
jrgriffiniii reviewed Feb 10, 2020
View reviewed changes
app/services/iiif_service.rb

# IIIF::Presentation doesn't support IIIF 3. Fortunately we don't use much
# of it, so a simple wrapper with a label for a manifest gets us there.
class IIIF3Manifest < SimpleDelegator
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@jrgriffiniii jrgriffiniii merged commit b21f38f into master Feb 10, 2020
@jrgriffiniii jrgriffiniii deleted the 663-recordings-sync branch February 10, 2020 20:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jrgriffiniii jrgriffiniii jrgriffiniii approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support syncing recordings or playlists from Figgy
3 participants
@tpendragon @coveralls @jrgriffiniii