Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

atty potential unaligned read #9 #684

Closed
Martin1887 opened this issue Jul 1, 2023 · 0 comments · Fixed by #685
Closed

atty potential unaligned read #9 #684

Martin1887 opened this issue Jul 1, 2023 · 0 comments · Fixed by #685
Labels

Comments

@Martin1887
Copy link
Collaborator

Martin1887 commented Jul 1, 2023

On windows, atty dereferences a potentially unaligned pointer.

In practice however, the pointer won't be unaligned unless a custom global allocator is used.

In particular, the System allocator on windows uses HeapAlloc, which guarantees a large enough alignment.

To fix this, there are two alternatives:

This is a low risk vulnerability but it should be fixed. This is a dependency of criterion and clap, so the versions of these crates must be checked.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant