Skip to content
This repository has been archived by the owner on Jan 30, 2024. It is now read-only.

Commit

Permalink
Problem: pre-flight check errors when there is an upgraded pip
Browse files Browse the repository at this point in the history
in a system-wide venv

and when the package is installed as an RPM in the prereq role
at an acceptable version, so the pre-flight check should not
have tried to use a newer version from PyPI.

This is a regression from #6645. Previously many errors were ignored,
this error should still be ignored too until system-wide packages
support is removed.

fixes: #6690
pre-flight check errors when there is an upgraded pip in a system-wide venv
https://pulp.plan.io/issues/6690

re: #6645
pre-flight check does not work properly when it needs a prereq role
https://pulp.plan.io/issues/6645
  • Loading branch information
mikedep333 committed May 8, 2020
1 parent 37aab66 commit cd0e669
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 0 deletions.
1 change: 1 addition & 0 deletions CHANGES/6690.bugfix
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Fixed pre-flight check producing an error (and accidentally enforcing) when trying & failing to build certain packages from PyPI that are actually available as a system-wide (RPM/deb-installed) package in the virtualenv. This issue was never present on the previous release, only on the develoment branch.
4 changes: 4 additions & 0 deletions roles/pulp/tasks/install.yml
Original file line number Diff line number Diff line change
Expand Up @@ -224,6 +224,10 @@
- name: Re-run pre-flight check after plugin prereq roles
include_tasks: preflight_function.yml
# if it didn't succeed last time
vars:
failed_condition: >
(compatibility.rc != 0) and
("AttributeError: module \'setuptools.build_meta\' has no attribute \'__legacy__\'" not in compatibility.stderr)
when:
- pulp_source_dir is undefined
- compatibility is defined
Expand Down

0 comments on commit cd0e669

Please sign in to comment.