This repository has been archived by the owner on Jan 30, 2024. It is now read-only.
Prevent rq from logging secrets #139
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Though the issue is specific about certain cases that shouldn't be logged, we do not have fine control over what rq logs, so the solution is to disable logging of the description (which includes the job arguments). https://pulp.plan.io/issues/5012 fixes #5012
asmacdo
force-pushed
the
5012-rq-dont-log-secrets
branch
from
a6fd4fb
to
a1838b1
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Though the issue is specific about certain cases that shouldn't be
logged, we do not have fine control over what rq logs, so the solution
is to disable logging of the description (which includes the job
arguments).
https://pulp.plan.io/issues/5012
fixes #5012