-
Notifications
You must be signed in to change notification settings - Fork 81
Add posgresql extension debversion to pulp db #166
Conversation
@@ -2,6 +2,7 @@ | |||
pulp_preq_packages: | |||
- python3 | |||
- python3-venv | |||
- postgresql-11-debversion |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This package needs packaging on the RPM side.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mdellweg I am a Fedora packager. I can help you with this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
libapt-pkg5.0 would be a new dependency.
We can use the mageia 4.0 RPMs as a starting point:
https://mageia.pkgs.org/cauldron/mageia-core-release-i586/libapt-pkg4-0.5.15lorg3.94-33.mga8.i586.rpm.html
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe i have seen this package. Is mageia not a direct descendent of mandrake? I think, they ported apt to use rpm, and consequently patched all the debian package specific stuff away.
Therefore i was persuing another way. I looked for the single function we need, and patched that one into the postgres-extension:
https://github.com/ATIX-AG/foreman-packaging/blob/add_postgresql_debversion/packages/katello/postgresql-debversion/0001-Copy-relevant-code-from-apt-pkg-to-ease-packaging.patch
This drops the dependency on libapt completely.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Started an effort to write a spec file for this:
theforeman/foreman-packaging#4540
Still i am not really sure that is the place to make it available for all pulp users.
4839eb7
to
f377d9b
Compare
In order to make the extension available to the test_database, i needed to run:
But i don't feel like we want to activate this extension on the global template for all future databases. |
f377d9b
to
a4329fb
Compare
a4329fb
to
7f047d6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In order to make the extension available to the test_database, i needed to run:
# /usr/local/lib/pulp/bin/ansible localhost --become --become-user postgres -m postgresql_ext -a "db=template1 ext=debversion"
But i don't feel like we want to activate this extension on the global template for all future databases.
Similar to how we introduced the prereq_role sub-variable for pulp-rpm, we could do something similar for postgres extensions.
Maybe it's even better to use something like https://github.com/dimitri/pgextwlist . |
7f047d6
to
ab74fcf
Compare
ab74fcf
to
8cd6d5a
Compare
WARNING!!! This PR is not attached to an issue. In most cases this is not advisable. Please see our PR docs for more information about how to attach this PR to an issue. |
Let's reopen when we start working on this again. |
No description provided.