Fix installer for ruby bindings #212
Conversation
|
@bmbouter do you think we have to install rubygems ruby-devel also? |
|
@fabricio-aguiar yes since you have the fix available let's merge it. |
| @@ -15,6 +15,7 @@ | |||
| - tree | |||
| - wget | |||
| - gnupg | |||
| - rubygems | |||
There was a problem hiding this comment.
FYI: I tested this by running in a debian:10 container "apt-get install rubygems". It maps to installing the "ruby" package which includes the gem command.
| pip install ./$1-client | ||
| ;; | ||
| ruby) | ||
| cd $1-client | ||
| gem build $1_client |
There was a problem hiding this comment.
Are these a safe way to concatenate strings to these bash special variables? I know that bash variables can at least have underscores in them, but special vars (like those beginning with numbers) may follow different rules. If not safe, add the curly brackets.
There was a problem hiding this comment.
I tested locally(fedora 30 box) and it worked
|
@fabricio-aguiar can you update pulplift to use this commit also? |
Bug:
if someone does:
pbindings pulp_file rubyit will generate ruby bindings, try to pip install it, and it won't install ruby gem.
This PR fixes this bug