Skip to content
This repository has been archived by the owner on Jan 30, 2024. It is now read-only.

Commit

Permalink
Problem: pre-flight check does not understand the plugin "upgrade" bo…
Browse files Browse the repository at this point in the history
…olean

Solution: Call `pip-compile -P pulp-file -P pip-compile` for example,
where each named plugin has `upgrade: true`.
The requirements.in will continue to list all plugins, and their
specified versions (if any.)

fixes: #6643
pre-flight check does not understand the plugin "upgrade" boolean
https://pulp.plan.io/issues/6643

re: https://pulp.plan.io/issues/6623
pulpcore and plugin pre-flight check seems to not be enforcing and then installer fails at collectstatic
  • Loading branch information
mikedep333 committed May 6, 2020
1 parent 0ad5fc2 commit 7c5365d
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 1 deletion.
1 change: 1 addition & 0 deletions CHANGES/6643.bugfix
@@ -0,0 +1 @@
Fixed the pulpcore/plugin compatibility check accidentally enforcing on upgrades when plugins have their upgrade variable specified, and the latest version of the plugin actually is compatible.
5 changes: 4 additions & 1 deletion roles/pulp/tasks/install.yml
Expand Up @@ -197,7 +197,10 @@
changed_when: false

- name: Run pip-compile to check pulpcore/plugin compatibility
command: '{{ pulp_install_dir }}/bin/pip-compile'
command: '{{ pulp_install_dir }}/bin/pip-compile
{% for plugin, value in pulp_install_plugins.items() %}
{% if value["upgrade"]|default(false, true) %} -P {{ plugin }} {% endif %}
{% endfor %}'
args:
chdir: '{{ pulp_install_dir }}'
register: compatibility
Expand Down

0 comments on commit 7c5365d

Please sign in to comment.