Skip to content
This repository has been archived by the owner on Jan 30, 2024. It is now read-only.

Commit

Permalink
support per pulp_install_plugins source_dir vcs
Browse files Browse the repository at this point in the history
Problem: The requirements.in file that pip-compile consumes only
includes the package name and not the source_dir

Solution: Per pulp_install_plugins source_dir entries that are vcs are
added to the pip-compile requirements.in so that the pip-compile line
will have all the information available to decide if requirements and
dependencies are met.

fixes: #7382
https://pulp.plan.io/issues/7382
  • Loading branch information
chrismeyersfsu committed Aug 25, 2020
1 parent 5a44cb3 commit 85bd023
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 0 deletions.
1 change: 1 addition & 0 deletions CHANGES/7382.bugfix
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Fixed bug where pulp_install_plugins source_dir vcs was being used when checking depdencies via pip-compile
4 changes: 4 additions & 0 deletions roles/pulp_common/templates/requirements.in.j2
Original file line number Diff line number Diff line change
@@ -1,6 +1,10 @@
pulpcore=={{ pulp_version }}
{% for plugin, value in pulp_install_plugins_normalized.items() %}
{% if value['source_dir'] is defined -%}
-e {{ value['source_dir'] }}
{% else -%}
{{ plugin }}{% if value['version'] is defined and value['version']|length %}=={{ value['version'] }}{% endif %}
{% endif %}

{% endfor %}
# Any plugins listed below were already installed but not specified in
Expand Down

0 comments on commit 85bd023

Please sign in to comment.