Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The Release workflow fails when there are no changelog entries in the release #525

Open
quba42 opened this issue Nov 16, 2021 · 3 comments

Comments

@quba42
Copy link
Contributor

quba42 commented Nov 16, 2021

Happens during the "Update Redmine" step during publish, so most of the release has already happened (packages are updated on pypi and rubygems, etc.).

The error encountered is:

python3 .ci/scripts/redmine.py $REDMINE_QUERY_URL $MILESTONE_URL $RELEASE
Traceback (most recent call last):
  File ".ci/scripts/redmine.py", line 27, in <module>
    status = redmine.issue.get(int(issue)).status.name
ValueError: invalid literal for int() with base 10: ''

See here for the full workflow: https://github.com/pulp/pulp_deb/runs/4223060338?check_suite_focus=true

Expectation:

If there are no issues in the release, then .ci/scripts/redmine.py does not need to do anything, and should just return 0!

Release steps not performed because they come after the error:

  • Create release on GitHub
  • Cleanup repository before making changelog PR
  • Stage changelog for master branch
  • Create Pull Request for Changelog

=> The changelog steps might also need some special handling to deal with this special case of "no changelog entries".

@stale
Copy link

stale bot commented May 24, 2022

This issue has been marked 'stale' due to lack of recent activity. If there is no further activity, the issue will be closed in another 30 days. Thank you for your contribution!

@stale stale bot added the stale label May 24, 2022
@quba42
Copy link
Contributor Author

quba42 commented May 30, 2022

Not sure if this is still an issue (have not had an empty release in a while).

@stale
Copy link

stale bot commented May 30, 2022

This issue is no longer marked for closure.

@stale stale bot removed the stale label May 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant