This repository has been archived by the owner on Jan 9, 2023. It is now read-only.
Add models for pre0migrating pulp2 repository related data #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
goosemania
commented
Aug 25, 2019
ipanova
reviewed
Aug 27, 2019
| pulp3_repository_version (models.OneToOneField): Pulp 3 repository version which Pulp 2 | ||
| repository was migrated to | ||
| """ | ||
| pulp2_repo_id = models.CharField(max_length=255) # in Pulp2 it might be longer? |
There was a problem hiding this comment.
can we use textfield then?wdyt?
There was a problem hiding this comment.
it can be but it's a part of a unique index now, so it's better be limited
ipanova
reviewed
Aug 27, 2019
| repository was migrated to | ||
| """ | ||
| pulp2_repo_id = models.CharField(max_length=255) # in Pulp2 it might be longer? | ||
| pulp2_object_id = models.CharField(max_length=255) |
There was a problem hiding this comment.
what is the reason having both object_id and repo_id? can we refer only to repo_id?
There was a problem hiding this comment.
Since we can run a migration multiple times, it's possible that a repo with a specific repo_id can be removed and then created again and it will be a completely different repo. Migration plugin needs to distinguish between those.
ipanova
reviewed
Aug 27, 2019
ipanova
reviewed
Aug 27, 2019
ipanova
approved these changes
Aug 27, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #5306
https://pulp.plan.io/issues/5306