Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for mirror flag when syncing rpm repositories #212

Merged
merged 1 commit into from Apr 30, 2021

Conversation

vonsch
Copy link
Contributor

@vonsch vonsch commented Apr 26, 2021

[noissue]

@vonsch
Copy link
Contributor Author

vonsch commented Apr 26, 2021

Btw I also considered if it would be better to use --mirror/--no-mirror python click options instead of --mirror True/--mirror False, but not sure what's better.

@mdellweg
Copy link
Member

We use --bool/--no-bool everywhere else.

@vonsch
Copy link
Contributor Author

vonsch commented Apr 26, 2021

@mdellweg thanks for suggestion, I modified PR

@vonsch vonsch changed the title Support for --mirror <boolean> flag when syncing rpm repositories Support for mirror flag when syncing rpm repositories Apr 26, 2021
Copy link
Member

@mdellweg mdellweg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@daviddavis do you think, we need a changelog here?

@daviddavis
Copy link
Contributor

I don't see the harm in adding a changelog. It's good to always call out new additions.

That said, I have no objection to not having a changelog either.

@vonsch
Copy link
Contributor Author

vonsch commented Apr 28, 2021

@mdellweg If you prefer to have changelog entry, I can easily add one. However if I understand the CHANGES/ directory layout and file naming well, I must first create some github issue and then reference it in the ```CHANGES/<issue_number>.feature, right?

@daviddavis
Copy link
Contributor

You could just use this PR number (ie CHANGES/212.feature).

@vonsch
Copy link
Contributor Author

vonsch commented Apr 28, 2021

@daviddavis ok, added

Copy link
Member

@mdellweg mdellweg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much!

@mdellweg mdellweg added this to the 0.8.0 milestone Apr 28, 2021
@mdellweg mdellweg merged commit 1b163d3 into pulp:develop Apr 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants