Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update make test-coverage make target #35

Closed
jeremycline opened this issue Nov 9, 2015 · 2 comments
Closed

Update make test-coverage make target #35

jeremycline opened this issue Nov 9, 2015 · 2 comments

Comments

@jeremycline
Copy link
Contributor

pulp_smash.utils.rand_str was added by #28, but tests do not exist for the function. Furthermore, the missing coverage is not detected by the current make test-coverage.
@Ichimonji10
Copy link
Contributor

👍

@Ichimonji10 Ichimonji10 mentioned this issue Nov 17, 2015
Closed
@Ichimonji10
Copy link
Contributor

I'd also like to rename the pulp_smash.utils.rand_str function to uuid4. The latter name more accurately reflects what the function does: it calls the uuid4 function from the standard library and casts it to a unicode string. Alternately, we can make the function return more random strings.

@Ichimonji10 Ichimonji10 mentioned this issue Nov 17, 2015
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Ichimonji10 @jeremycline