Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor user and repository CRUD tests #37

Closed
Ichimonji10 opened this issue Nov 9, 2015 · 2 comments
Closed

Refactor user and repository CRUD tests #37

Ichimonji10 opened this issue Nov 9, 2015 · 2 comments

Comments

@Ichimonji10
Copy link
Contributor

The tests in modules tests.platform.api_v2.test_user and tests.platform.api_v2.test_repository could use some refactoring. They were my first pass at writing tests in Pulp Smash, and while reasonably good, there's a few things that really bug me about their structure. There's repetitive setUpClass and tearDownClass code, there's a few too many class variables, and the use of numeric indices makes the tests less readable. (See #28 (comment).) Let's refactor them to hew more closely to the example in tests.platform.api_v2.test_search.
@Ichimonji10
Copy link
Contributor Author

@asmacdo Something to keep in mind when writing importer and distributor tests.

@Ichimonji10
Copy link
Contributor Author

Closing in favor of #40.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Ichimonji10