Removes sudo from the buildah command #64
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@dkliban i had an impression that volume mount was needed because it is used by automation hub?now that we remove it , won't they be impacted? |
|
@ipanova It is not strictly required. When the build container starts up, it automatically makes the context directory available for operations such as COPY. That reminds me that I should update the example Containerfile with this PR. |
This patch also removes the use of a volume mount. There seems to be a problem with using a volume mount when running buildah inside a container. fixes: #5895 https://pulp.plan.io/issues/5895
ipanova
approved these changes
Mar 5, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch also removes the use of a volume mount. There seems to be a problem with using a
volume mount when running buildah inside a container.
fixes: #5895
https://pulp.plan.io/issues/5895