Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support the debug .ddeb package type #384

Open
pulpbot opened this issue Jan 4, 2022 · 7 comments
Open

Support the debug .ddeb package type #384

pulpbot opened this issue Jan 4, 2022 · 7 comments
Labels
.feature CHANGES/<issue_number>.feature Looking_for_Contributor For valid issues that the plugin maintainers have no plans to implement.

Comments

@pulpbot
Copy link
Member

pulpbot commented Jan 4, 2022

Author: lieter (lieter)

Redmine Issue: 6757, https://pulp.plan.io/issues/6757


From Ubuntu Bionic onward, Canonical has patched debuild to change the suffix for debug ($package-dbgsym_$version) package from .deb to .ddeb.

When attempting to upload packages with this suffix, the tasks has the following error:

  File "/home/lieter/.virtualenvs/pulp3-devel/lib/python3.8/site-packages/rq/worker.py", line 886, in perform_job
    rv = job.perform()
  File "/home/lieter/.virtualenvs/pulp3-devel/lib/python3.8/site-packages/rq/job.py", line 664, in perform
    self._result = self._execute()
  File "/home/lieter/.virtualenvs/pulp3-devel/lib/python3.8/site-packages/rq/job.py", line 670, in _execute
    return self.func(*self.args, **self.kwargs)
  File "/home/lieter/src/Pulp/pulpcore/pulpcore/app/tasks/base.py", line 40, in general_create
    serializer.is_valid(raise_exception=True)
  File "/home/lieter/.virtualenvs/pulp3-devel/lib/python3.8/site-packages/rest_framework/serializers.py", line 243, in is_valid
    raise ValidationError(self.errors)

This is because the plugin (rightfully) assumes that all packages are called .deb (or .udeb for installer packages). I believe adding a 'DebugPackage` model that inherits from Package (changing only SUFFIX) would be a good addition to pulp_deb.

The workaround here would be to upload the .ddeb with a relatve_path ending with .deb, but I don't know if Ubuntu's apt/dpkg would like that (afaik, it accepts it).

@pulpbot pulpbot added this to the Wishlist milestone Jan 4, 2022
@pulpbot
Copy link
Member Author

pulpbot commented Jan 4, 2022

From: lieter (lieter)
Date: 2020-05-18T15:54:14Z


Work in progress PR is here: #170

@pulpbot
Copy link
Member Author

pulpbot commented Jan 4, 2022

From: @quba42 (quba42)
Date: 2020-08-12T07:39:09Z


Some more information on this package type:

@pulpbot
Copy link
Member Author

pulpbot commented Jan 4, 2022

From: @quba42 (quba42)
Date: 2020-08-12T10:42:08Z


I finally found were to find example packages as well:

Found via:

@pulpbot
Copy link
Member Author

pulpbot commented Jan 4, 2022

From: @quba42 (quba42)
Date: 2020-08-12T10:43:50Z


Without having looked in detail at the WIP PR already provided, I think these ddeb packages should be pretty analogous to udeb packages in the pulp_deb plugin implementation.

@quba42 quba42 removed New labels Jan 31, 2022
@stale
Copy link

stale bot commented May 25, 2022

This issue has been marked 'stale' due to lack of recent activity. If there is no further activity, the issue will be closed in another 30 days. Thank you for your contribution!

@stale stale bot added the stale label May 25, 2022
@quba42 quba42 removed this from the Wishlist milestone Aug 23, 2023
@stale
Copy link

stale bot commented Aug 23, 2023

This issue is no longer marked for closure.

@stale stale bot removed the stale label Aug 23, 2023
@quba42 quba42 added .feature CHANGES/<issue_number>.feature and removed Migrated from Redmine labels Aug 23, 2023
@quba42
Copy link
Collaborator

quba42 commented Aug 23, 2023

This is a feature request for the currently unsupported debug package type.

@quba42 quba42 changed the title Debug packages from Ubuntu Bionic and newer can't be uploaded Support the debug .ddeb package type Aug 23, 2023
@quba42 quba42 added the Looking_for_Contributor For valid issues that the plugin maintainers have no plans to implement. label Aug 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
.feature CHANGES/<issue_number>.feature Looking_for_Contributor For valid issues that the plugin maintainers have no plans to implement.
Projects
None yet
Development

No branches or pull requests

2 participants