This repository has been archived by the owner on Dec 7, 2022. It is now read-only.
1148556 - Validate repo-registry-id to ensure compatibility with Docker #52
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Sayli Karmarkar (skarmark@redhat.com) | ||
| Austin Macdonald (amacdona@redhat.com) |
There was a problem hiding this comment.
What are you, a librarian?
|
I think you should make sure that one function returns a bool as it says it does. You should also unit test that one function directly, ensuring that the returned type is bool. No need for re-review once you do that, LGTM! |
asmacdo
added a commit
that referenced
this pull request
Jan 8, 2015
1148556 - Validate repo-registry-id to ensure compatibility with Docker
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BZ -1148556
Docker registry id's cannot contain uppercase letters, so they should be validated. If the repo-registry-id is not specified, it defaults to repo id, so in that case, the repo-id needs to be validated differently.
This PR gives a less than ideal error back to the user. This problem is fixed in pulp/pulp#1487