Updates downstream bug state #252
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bmbouter
force-pushed
the
2351-American-Stout
branch
2 times, most recently
from
7fe2b66
to
a118b69
Compare
dkliban
requested changes
Nov 21, 2016
| issue.status.name in upstream_POST_minus: | ||
| msg = 'The downstream bug %s is at POST+ but the upstream bug %s ' \ | ||
| 'at POST-. Something is wrong.' % (bug.id, issue.id) | ||
| raise RuntimeError(msg) |
There was a problem hiding this comment.
you should probably accumulate these error messages like you do with the linking problems. Then raise an Exception at the end with text from all the problems found along the way.
bmbouter
force-pushed
the
2351-American-Stout
branch
2 times, most recently
from
94c680a
to
7dcdf84
Compare
This puts several changes in place: * The downstream bug state is transitioned to POST when the upstream bug is at MODIFIED+. * If the downstream bug is at POST+ and the upstream bug is at POST- it fails the job which notifies a human. * Logic to ignore transitioning a downstream bug if there is a Foreman issue associated with it. * Some small fixes where lines were > 100 chars. * Some small docs improvements https://pulp.plan.io/issues/2351 closes #2351
bmbouter
force-pushed
the
2351-American-Stout
branch
from
7dcdf84
to
2ead2b4
Compare
dkliban
approved these changes
Nov 21, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This puts 4 changes in place:
The downstream bug state is transitioned to POST
when the upstream bug is at MODIFIED+.
If the downstream bug is at POST+ and the upstream
bug is at POST- it fails the job which notifies a
human.
A placeholder for a future Foreman integration point
where downstream transitions will not occur if the
upstream Foreman bug is not at MODIFIED+.
Some small fixes where lines were > 100 chars.
https://pulp.plan.io/issues/2351
closes #2351