Adds use of GetLocalUnitsStep to track which units already exist in Pulp #212
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| puppet_manifest = self._extract_metadata(module_path) | ||
| module = Module.from_metadata(puppet_manifest) | ||
| remote_unit_keys.append(module.unit_key_str) | ||
| list_of_modules.append(module) | ||
|
|
||
| pub_step = publish_step.GetLocalUnitsStep(importer_type=constants.IMPORTER_TYPE_ID, available_units=list_of_modules, repo=self.repo) |
There was a problem hiding this comment.
It looks like the init method expects importer_type as a positional arg instead of a kwarg[0].
Also the line is a bit long (but will get shorter once importer_type isn't a kwarg, so that's okay!).
[0] https://github.com/pulp/pulp/blob/master/server/pulp/plugins/util/publish_step.py#L1182
|
Other than the kwarg -> arg thing, this looks good. Are there unit tests to go with this, or did all those get disabled? |
During conversion to mongoengine the check for already existing units broke. This fixes that problem. https://pulp.plan.io/issues/1440 closes #1440
dkliban
added a commit
that referenced
this pull request
Jan 28, 2016
Adds use of GetLocalUnitsStep to track which units already exist in Pulp
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
During conversion to mongoengine the check for already existing units
broke. This fixes that problem.
https://pulp.plan.io/issues/1440
closes #1440