Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add comps.xml upload support #2313

Closed
fao89 opened this issue Dec 22, 2021 · 5 comments
Closed

Add comps.xml upload support #2313

fao89 opened this issue Dec 22, 2021 · 5 comments
Assignees
Labels
Milestone

Comments

@fao89
Copy link
Member

fao89 commented Dec 22, 2021

Author: Skullman (Skullman)

Redmine Issue: 9225, https://pulp.plan.io/issues/9225


In RHUI3 (Pulp 2) it is possible to upload comps.xml metadata into custom repository using API:
self.pulp.upload_api.import_upload(upload_id, repo_id, TYPE_ID_PKG_GROUP, unit_key, metadata)

@fao89
Copy link
Member Author

fao89 commented Dec 22, 2021

From: @dralley (dalley)
Date: 2021-08-11T19:07:37Z


This is a very-nice-to-have item for RHUI and technically a feature gap with Pulp 2

@fao89
Copy link
Member Author

fao89 commented Dec 22, 2021

From: pulpbot (pulpbot)
Date: 2021-10-24T20:51:49Z


PR: #2159

@fao89
Copy link
Member Author

fao89 commented Dec 22, 2021

From: @ggainey (ggainey)
Date: 2021-10-25T14:33:46Z


PR #2159 implements the following REST call/behavior at POST /pulp/api/v3/rpm/comps/ :

  • file= [required] : full path to a comps.xml file.
  • repository= [optional] : rpm_repository_href, a repository to add the resulting comps-Content-units to
  • replace= [optional] : boolean, used only if repository= specified. If true, creates a new repo-version in the repository by first removing existing comps-Content from repository.latest_version() and then adding the ones contained in file=.

The pulp_hrefs of all comps-Content found in file= are returned in created_resources, even if they already existed. If repository= is specified, the pulp_href of the new repository-version is also in created_resources. This may change before the PR is merged, however.

@Skullman - how does this sound to you? Does it meet your needs? Or do you need the specific comps-Content-units be independently createable (ie, PackageGroup, PackageEnvironment, PackageLangpack, PackageCategory all with their own POST calls?)

@fao89
Copy link
Member Author

fao89 commented Dec 22, 2021

From: @ggainey (ggainey)
Date: 2021-11-03T18:38:49Z


Applied in changeset commit:4ff731591b4f5e4074ed8beeeaf718dfa269e3ac.

@dralley
Copy link
Contributor

dralley commented Dec 22, 2021

#2319 (comment)

@dralley dralley closed this as completed Dec 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants