Compress sqlite repodata files. #1306
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ipanova
force-pushed
the
i4516
branch
2 times, most recently
from
92a53be
to
932b780
Compare
dralley
reviewed
Mar 25, 2019
pulp_rpm/app/tasks/publishing.py
Outdated
| open(repomd_path, "w").write(repomd.xml_dump()) | ||
| repomd_f = open(repomd_path, "w") | ||
| repomd_f.write(repomd.xml_dump()) | ||
| repomd_f.close() |
There was a problem hiding this comment.
Nice catch on the file handler leak! Is there any reason not to use a context manager here? If we can, I think we should.
with open(repomd_path, "w") as repomd_f:
repomd_f.write(repomd.xml_dump())
dralley
changed the title
dralley
approved these changes
Mar 26, 2019
|
@dralley i do not have any strong preference. I tested the work-flow on fedora and package manager did not complain about uncompressed files, but it was be the problem for centos and probably rhel. |
|
Sounds good, I suppose QE should determine if it needs one and how to do so if it would be difficult to test on a non-centos system. Probably leave a note on the if statement mentioning this special case though. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #4516
closes #4030
https://pulp.plan.io/issues/4516
https://pulp.plan.io/issues/4030