New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remote.get_downloader() needs to include remote in kwargs for Factory.build() #1905
Comments
From: @bmbouter (bmbouter) I agree we should do something, but it's a little unclear exactly what at the moment. Some IRC or video chat may be helpful. Having |
From: @bmbouter (bmbouter) @dkliban and I talked this over and the summary is that this plugin pattern is not a good pattern and we should do the plugin code differently. The pulpcore code should likely stay the same. The problems with the current plugin code are:
The problem with continuing down this roadTo have the base implementation of the factory pass along the Remote to a pulpcore provided downloader (not a subclassed one) we would have to add 'remote' as a param to either HttpDownloader and FileDownloader, or BaseDownloader. That would be strange because Solution (do all the steps below):
|
This issue has been marked 'stale' due to lack of recent activity. If there is no further activity, the issue will be closed in another 30 days. Thank you for your contribution! |
This issue is no longer marked for closure. |
Author: @dkliban (dkliban@redhat.com)
Redmine Issue: 6965, https://pulp.plan.io/issues/6965
The plugin writer docs need to be updated to explain how custom downloaders should be implemented. The documenation should be based on the information provided in comment 2 of this issue.
Original Description
Multiple plugins now override Remote.get_downloader() method in order to add the 'remote' to the kwargs[0].
The pulpcore implementation of Remote.get_downloader() should pass the 'remote' as a kwarg to the Factory.build() method[1].
[0] https://github.com/pulp/pulp_container/blob/master/pulp_container/app/models.py#L251
[1] https://github.com/pulp/pulpcore/blob/master/pulpcore/download/factory.py#L108
The text was updated successfully, but these errors were encountered: