Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add token authentication to pulpcore #2018

Open
pulpbot opened this issue Jan 17, 2022 · 2 comments
Open

Add token authentication to pulpcore #2018

pulpbot opened this issue Jan 17, 2022 · 2 comments

Comments

@pulpbot
Copy link
Member

pulpbot commented Jan 17, 2022

Author: @gerrod3 (gerrod)

Redmine Issue: 8939, https://pulp.plan.io/issues/8939


Background

Token authentication hands out a secret token to be used by a user to authenticate themselves. These tokens are passed in through the Authorization HTTP header with each request usually in the form of TOKEN {USER_TOKEN}. Tokens need to be kept secret like passwords and should only be used with https. Token auth can be implemented many different ways, but the general workflow follows:

  1. User visits a token view with basic credentials to receive a token
  2. Server generates a token that can be used to authenticate that user for future requests
  3. User uses token for token for authentication on future requests
  4. Token expires after set time or user deletes/generates a new token

Token auth can easily be added using the pre-built token authentication available in DRF: https://www.django-rest-framework.org/api-guide/authentication/#tokenauthentication. Two popular methods for token authentication are simple HTTP tokens and JSON Web token (JWT).

Simple HTTP Tokens

Basic token authentication comes included in DRF and can be added by including rest_framework.authtoken in the INSTALLED_APPS list and by adding TokenAuthentication to DRF's DEFAULT_AUTHENTICATION_CLASSES setting. This creates a model for storing tokens in the database. obtain_auth_token is a default view for generating tokens that can be added for users to receive their tokens.

Pros

  • Simple to add and customize
  • Admins and users can track tokens that have been deployed
  • Lots of third party libraries that are built on top to add more functionality: Django-Rest-Durin, drfpasswordless, django-rest-knox, Djoser

Cons

  • Adds an extra model to the database to maintain.

JSON Web Tokens

Background: https://jwt.io/introduction. JWTs consist of three encoded strings separated by dots which are: the header, the payload and the signature. JWTs use the signatures of the token to validate the authenticity of a token and have no need for a database to store them. The header tells how the token is encoded and the payload contains information, called claims, about the token like the user and expiration time for the token. The signature is created from the private key of the server and the encoded strings of the header and payload to validate the token. JWTs usually use the Bearer schema inside the Authentication header, e.g.: Authentication: Bearer {USER_TOKEN}. Since the signature validates the token an expiration is added to the payload to be able to invalidate it. djangorestframework-simplejwt implements JWTs for DRF by generating two tokens for users. One is a short-lived access token to authenticate and the other is a longer-lived refresh token that can be used to get another acess token.

Pros

  • Simple to add using djangorestframework-simplejwt
  • No need for database models
  • Tokens expiration naturally built in

Cons

  • No way to manually delete/track tokens without a database table
  • Tokens need to be continuously fetch since long-lived tokens are ill-advised

Implementation Options

  1. Just use DRF's token auth or a pre-built DRF token auth package
  2. Just use JWT from djangorestframework-simplejwt
  3. Build a custom implementation on top of DRF tokens
@pulpbot
Copy link
Member Author

pulpbot commented Jan 17, 2022

From: @ipanova (ipanova@redhat.com)
Date: 2021-06-22T10:13:04Z


Has it been decided which implementation option will it be? In case jwt tokens, I'd like to see code ported from pulp-container into core so more plugins can benefit from it.

@dralley dralley added Feature and removed Assigned labels Feb 1, 2022
@stale
Copy link

stale bot commented May 24, 2022

This issue has been marked 'stale' due to lack of recent activity. If there is no further activity, the issue will be closed in another 30 days. Thank you for your contribution!

@stale stale bot added the stale label May 24, 2022
@dralley dralley removed the stale label May 25, 2022
@gerrod3 gerrod3 removed their assignment Aug 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants