-
-
Notifications
You must be signed in to change notification settings - Fork 125
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pulsar got closed by itself if I close the external terminal #979
Comments
Thanks a ton for reporting this! But, and someone feel free to correct me if I'm wrong, pretty sure this is expected behavior. When launching Pulsar from the command line that session then essentially owns the child process that is Pulsar. So when the parent process is killed then of course it'll kill any child process'. If it helps you can work around this within Windows itself by using something like But otherwise I'm not sure if there's that much that can be done on our end to configure this behavior. |
I'm betting that this is new behavior because @zhaolinlau has opened issues against this repo before and has probably used versions prior to 1.116. @zhaolinlau, is this something that was behaving differently on Windows before 1.116? |
Actually this is not a new behaviour, this issue occurred since the first release of the pulsar. |
OK, cool. Thanks for the report. Windows users: I'm curious if VSCode has the same behavior. If not, then it's within our ability to fix. |
Well this shouldn't be an expected behaviour because Atom and VsCodium don't have this issue. |
It's also not the behavior of Pulsar or Atom on macOS or (I think) Linux, so we should aim for uniformity here. |
So just checking this isn't the behavior on Atom's last released versions. Although, launching Atom via the CLI also doesn't provide any output to the console of what's going on, unlike Pulsar which does show significant output. I think it's the fact that we continually log output to the console that's doing us in. Unless we also do that on other platforms and it doesn't cause it to close there. |
Maybe it's something to do with how Or perhaps Atom adds some launcher batch ( EDIT: It should be launching this, I believe: https://github.com/pulsar-edit/pulsar/blob/master/resources/win/pulsar.cmd So we should make sure this |
@DeeDeeG Looking into the EDIT: So running So seems extra strange this would break things as I don't think we've changed much of this file. |
Thanks in advance for your bug report!
What happened?
When I open a project through terminal using
pulsar .
, it does open the project with pulsar, but after that I close the terminal, at the same time the pulsar will be closed if I close the terminal.Pulsar version
1.116.0
Which OS does this happen on?
🪟 Windows
OS details
11
Which CPU architecture are you running this on?
x86_64/AMD64
What steps are needed to reproduce this?
pulsar .
Additional Information:
No response
The text was updated successfully, but these errors were encountered: