New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ENH] Add class for the AlphaIMS implant #87
Conversation
…ctive isinstance checks and conditional sit.resize (in stimuli.py).
Hi Oliver, Thanks for your contribution - this is great! Would you mind also adding a test case in Thanks, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Found a typo that seems to be causing Travis to fail. Once you added your test case, it would be good to make sure that all tests pass before we merge the PR. Thanks, Michael
Looks like we still need a test-case for this, right? |
@arokem: Yep. I was trying to add it myself, but it looks I can only edit files that have been changed as part of the PR. The test file isn't one of them. |
Hmm. If @oliver-contier doesn't do it in the next few weeks, you can also fetch his branch down to your machine, do the edits on a branch derived from this branch, and then push it up as a new PR. |
* update develop version numbers * Add new citing papers * move plot_fundus to viz module * fix nasal/temporal labeling for left eyes * rename axons to bundles * Update README.md * Allow passing alpha constant to grid class (#86) * Allow passing alpha constant to grid class * Fixed PEP errors * fixed more PEP errors * revert to pep compiling with local flake * changed travis specifications * changed travis file & binary operators * pep8 change * Changed dask parameters from deprecated version * Update references * ENH: Switch to codecov (#91) Add codecov to Travis yml * add message in plot_fundus when loc_od_x has wrong sign * Add citing article * BF: Import `factorial` from `scipy.special` (#94) Apparently as of scipy 1.0.0 this function was moved out of `scipy.misc`. * Create CONTRIBUTING.md * Update issue templates * Create CODE_OF_CONDUCT.md * [ENH] Add class for the AlphaIMS implant (#87) * Added class for the AlphaIMS implant (in implants.py) and added respective isinstance checks and conditional sit.resize (in stimuli.py). * fix typo in isalphaims * Add RTD integration: badge, updated conf.py, requirements.txt * Add boston-train-combined.mp4 * Add boston-train-combined.gif * Create PULL_REQUEST_TEMPLATE.md (#126) * [TST] Continuous integration with GitHub Actions for v0.5 (#129) * add GitHub action on push; skip tests that require ffmpeg skip ffmpeg doctests; fix flake8 * mark parfor test as expected fail * add codecov * drop Py2.7 * change pytest dir * fix codecov path * remove Travis remove Py3.8 from matrix add artifact upload pip install wheel add TestPyPI upload/verification add runs-on build on matrix.os build on matrix.os fix syntax error * fix Matplotlib issue on Mac OS X fix flake8 try to upgrade setuptools * try to fix Windows io.h issue try to fix Windows io.h issue try to fix Windows io.h issue try to fix Windows io.h issue try to fix Windows io.h issue try to fix Windows io.h issue try to fix Windows io.h issue try to fix Windows io.h issue try to fix Windows io.h issue try to fix Windows io.h issue try to fix Windows io.h issue try to fix Windows io.h issue try to fix Windows io.h issue try to fix Windows io.h issue try to fix Windows io.h issue fix Windows env fix Windows env fix Windows env add includes ucrt, um, shared add LIB, PATH add LIB, PATH add LIB, PATH install matplotlib on Win debug win workflow debug win workflow debug win workflow debug win workflow * add Ubuntu 16.04, remove wheel building * add supported platforms to README; document the workflow file * fix checkout version * [TST] Automatic wheelhouse build using Azure Pipelines (#130) * Set up CI with Azure Pipelines * Try to switch to Py35 * Install requirements * Skip Py27 * Skip Python 3.8 * Add CIBW_BEFORE_BUILD * Add CIBW_BEFORE_BUILD_LINUX * Update requirements.txt * Update CIBW_BEFORE_BUILD_LINUX * Update CIBW_BEFORE_BUILD_LINUX * Update azure-pipelines.yml * add new release instructions to doc * add azure triggers * Remove pr from azure-pipelines.yml * Add pr to azure-pipelines.yml
... and added respective isinstance checks and conditional sit.resize (in stimuli.py).
The implant parameters are from the following paper:
@article{Stingl2015, author = {Stingl, Katarina and Bartz-Schmidt, Karl Ulrich and Besch, Dorothea and Chee, Caroline K. and Cottriall, Charles L. and Gekeler, Florian and Groppe, Markus and Jackson, Timothy L. and MacLaren, Robert E. and Koitschev, Assen and Kusnyerik, Akos and Neffendorf, James and Nemeth, Janos and Naeem, Mohamed Adheem Naser and Peters, Tobias and Ramsden, James D. and Sachs, Helmut and Simpson, Andrew and Singh, Mandeep S. and Wilhelm, Barbara and Wong, David and Zrenner, Eberhart}, doi = {10.1016/j.visres.2015.03.001}, journal = {Vision Research}, pages = {149--160}, publisher = {Elsevier Ltd}, title = {{Subretinal Visual Implant Alpha IMS - Clinical trial interim report}}, url = {http://dx.doi.org/10.1016/j.visres.2015.03.001}, volume = {111}, year = {2015} }