Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ui showing behind apps in viewer when looking at an image or video #1104

Closed
Jeefongithub opened this issue Apr 1, 2024 · 6 comments
Closed
Labels
fixed-upstream Fixed in an upstream package

Comments

@Jeefongithub
Copy link

Describe the bug
A clear and concise description of what the bug is.

Hard to describe I'll attach some screenshots. when openning a photo or video the ui at the top of the window shows behind nextcloud's top bar preventing interactions

To Reproduce
Steps to reproduce the behavior:

open photo or video

Screenshots
If applicable, add screenshots to help explain your problem.

image
image

Platform:

  • OS: [e.g. iOS] Debian 12
  • Browser: [e.g. Chrome, Safari] floorp (firefox fork) 11.11.2
  • Memories Version: [e.g. 4.1.0] 7.1
  • Nextcloud Version: [e.g. 25.0.6] 28.0.4
  • PHP Version: [e.g. 8.1] 8.3.2

Additional context
Add any other context about the problem here.

  • Any errors in the JS console?
  • Any errors in the Nextcloud server logs?
@Jeefongithub Jeefongithub added the needs triage To be triaged label Apr 1, 2024
@pulsejet
Copy link
Owner

pulsejet commented Apr 1, 2024

floorp

This right here, is the problem. Firefox only added support for the :has selector in Dec 2023, and it's likely that derivatives haven't updated yet. https://caniuse.com/css-has

The context is, using the has selector improves performance and simplicity by a lot, and Firefox has been lagging behind in this for a long time (even Safari has it since 2022). FF 121 finally enabled support making it baseline in 2024.

@Jeefongithub
Copy link
Author

gotcha. let me test some other browsers

@pulsejet pulsejet removed the needs triage To be triaged label Apr 1, 2024
@Jeefongithub
Copy link
Author

Thanks for explaining the issue with :has. I installed chromium and can confirm its working as expected. I'll open a request with floorp to add support from 121+

@pulsejet pulsejet added the fixed-upstream Fixed in an upstream package label Apr 1, 2024
@pulsejet
Copy link
Owner

pulsejet commented Apr 1, 2024

Nice, good to confirm that.

@nekr0z
Copy link

nekr0z commented Apr 14, 2024

FF 121 finally enabled support making it baseline in 2024.

With all respect, I have to point out that Nextcloud's baseline with regard do Firefox is Firefox ESR, which is 115 at this time. Until the next ESR is released (due in July or August, if I remember correctly), breaking compatibility is a bug.

@pulsejet
Copy link
Owner

Firefox is way overdue implementing this

🤷🏻

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fixed-upstream Fixed in an upstream package
Projects
None yet
Development

No branches or pull requests

3 participants