Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Photo deduplication #1112

Closed
corsac-s opened this issue Apr 3, 2024 · 12 comments
Closed

Photo deduplication #1112

corsac-s opened this issue Apr 3, 2024 · 12 comments
Labels
feature New feature or request
Milestone

Comments

@corsac-s
Copy link

corsac-s commented Apr 3, 2024

Is your feature request related to a problem? Please describe.
Photos present twice in the Nextcloud are displayed twice. For example I auto-upload the photos from my phone in a specific folder, and I also export photos both from my digital camera and from my phone in specific folders (mounted as external storage but available locally) for specific events. A photo taken from my phone will then appear twice once indexed.

Describe the solution you'd like
Similar photos (metadata content or maybe file hash) are only displayed once in the timeline etc.

Describe alternatives you've considered
Not sure, honestly.

Additional context
This might be a bit similar to #537 but here the files are exactly the same.

@corsac-s corsac-s added the feature New feature or request label Apr 3, 2024
@ChildLearningClub
Copy link
Sponsor

Are the file names identical, as well as the extension? And being uploaded to the same folder?

I had a similar issue with the Nextcloud app, uploading with lowercase .jpg extension and the same image exported from my phone through the PC having the same file name but with the uppercase .JPG extension. is this the same issue you’re experiencing?

@corsac-s
Copy link
Author

corsac-s commented Apr 3, 2024

In my case the photos are identical in content, have the same exif metadata, the same filename and same extension (and same case) and the same hash. They're not in the same folder.

In my case I know they are duplicate and I want to keep them that way, I just would like the indexing to only pick and display one of them.

@ChildLearningClub
Copy link
Sponsor

ChildLearningClub commented Apr 3, 2024

Okay, now I understand. So then there would also need to be away for you to choose, which one is displayed and which one is not. The .nomedia flag in the folders that you do not want indexed or visible is not what you are looking for?

@corsac-s
Copy link
Author

corsac-s commented Apr 3, 2024

I don't think it really matters which one is displayed (since they're identical).

.nomedia doesn't work: I do want all the folders (the one from my phone autoupload and the one from my manual uploads) to be indexed. I just would like identical photos not to be displayed twice on the timeline, explore etc.

@ChildLearningClub
Copy link
Sponsor

I see, thank you for clarifying. This would be a useful feature.

@ChildLearningClub
Copy link
Sponsor

ChildLearningClub commented Apr 3, 2024

I know this doesn’t completely solve your issue. But I guess until something like this does get implemented, if it’s not too much trouble you can separate The parent folders that each one goes into and then within the Memories settings only select the path to the ones that you want displayed.

Maybe you’re already doing this but just thought I would throw out the idea.

@corsac-s
Copy link
Author

corsac-s commented Apr 3, 2024

Thanks for the lead, but same that with .nomedia: I actually want photos from both folder to appear in the timeline, because autoupload has all my phone photos, and manual upload has all the camera photo + some phone photos and I want all the phone photos and all the camera photos (just not duplicates :)

@pulsejet pulsejet added this to the 7.1 milestone Apr 3, 2024
@pulsejet pulsejet modified the milestones: 7.1, 7.2 Apr 3, 2024
@corsac-s
Copy link
Author

corsac-s commented Apr 3, 2024

Wow, that was fast

@pulsejet
Copy link
Owner

pulsejet commented Apr 3, 2024

image

Just a note: this has the potential for false positives in certain cases, e.g. if just the metadata is different on both images is different then they might get incorrectly de-duplicated; which is why it'll default to false. These cases should be rare though.

@corsac-s
Copy link
Author

corsac-s commented Apr 3, 2024

Thanks! I don't really have the setup to build, test and confirm back. Are there artefacts from the github actions or something I can try?

@pulsejet
Copy link
Owner

pulsejet commented Apr 3, 2024

Not really, you'll need to wait for the next release or build from source

@pulsejet
Copy link
Owner

pulsejet commented Apr 6, 2024

Available with 7.2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants