Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pulumi output are not display during pulumi up #731

Closed
alexandre-girard-maif opened this issue Sep 27, 2022 · 15 comments · Fixed by #746
Closed

pulumi output are not display during pulumi up #731

alexandre-girard-maif opened this issue Sep 27, 2022 · 15 comments · Fixed by #746
Assignees
Labels
kind/bug Some behavior is incorrect or out of spec resolution/fixed This issue was fixed
Milestone

Comments

@alexandre-girard-maif
Copy link

alexandre-girard-maif commented Sep 27, 2022

What happened?

During the pulumi up action, if there is no resources to modify there is nothing display

Steps to reproduce

  1. Launch pulumi up when no resources are require modifications.

Expected Behavior

pulumi_up-3 18 1

Actual Behavior

pulumi_up-3 19 1

Output of pulumi about

No response

Additional context

No response

Contributing

Vote on this issue by adding a 👍 reaction.
To contribute a fix for this issue, leave a comment (and link to your pull request, if you've opened one already).

@alexandre-girard-maif alexandre-girard-maif added kind/bug Some behavior is incorrect or out of spec needs-triage Needs attention from the triage team labels Sep 27, 2022
@haoguo-wdc
Copy link

haoguo-wdc commented Sep 28, 2022

I think the problem might be bigger than the issue subject suggested.
I don't see Github action output even with resource diffs.
It could be a Github action issue though.

image

image

@alexandre-girard-maif
Copy link
Author

alexandre-girard-maif commented Sep 28, 2022

hi Hao,

just by curiosity, what's happen if you use the action with version 3.18.1 ?

@haoguo-wdc
Copy link

@alexandre-girard-maif
3.18.1 works as expected
image
compare to v3
image

@samanthawalter
Copy link

We've pinned to v3.19.0 because we're seeing this bug in v3.19.1

@alexandre-girard-maif
Copy link
Author

ok, so I will edit the title to explain it's not only when no change

@alexandre-girard-maif alexandre-girard-maif changed the title pulumi output are not display during pulumi if there is no modification pulumi output are not display during pulumi up Sep 28, 2022
@tlinhart
Copy link
Contributor

I'm experiencing the same issue, tried to ask on Slack but no response.

@RobbieMcKinstry
Copy link
Contributor

Hey all, sorry for the slow movement on this. I've been out with COVID for a while now, and the end of the quarter tore me away from triage duty. I will carve out some time this week to look into this.

v3.19.1 was a pretty modest upgrade so it's likely this bug won't take much snoof out and fix. I'm going to prioritize this over new features since it seems like this is impacting a number of users.

@RobbieMcKinstry RobbieMcKinstry self-assigned this Oct 5, 2022
@RobbieMcKinstry RobbieMcKinstry added this to the 0.79 milestone Oct 5, 2022
@RobbieMcKinstry
Copy link
Contributor

RobbieMcKinstry commented Oct 7, 2022

Just to follow up here, since users are reporting this bug is unique to v3.19.0, I bet the bug was introduced in #719. I haven't had a chance to build a repro yet, which is what I'll do now.

Nevertheless, separately, we took a stab at fixing it in #746 but if the bug originates in #719 I suspect that won't do the trick.

@DeanShackleyNewDay
Copy link

Hi Robbie, I have just retested and v3.19.1 breaks it for us as well. Previously we had just been through the release history and guessed it might have been the color output change that broke it. Nothing more than that, sorry can't be of more help on this.

@RobbieMcKinstry
Copy link
Contributor

No worries, thanks for the reply! :)

@simenandre
Copy link
Collaborator

Interesting ... When my stack fails, it shows the output. When it succeeds, it does not.

🚫 Build that failed:

Skjermbilde 2022-10-18 kl  20 13 11

✅ Build that succeeded:

Skjermbilde 2022-10-18 kl  20 13 52

Might be random … ?

@RobbieMcKinstry
Copy link
Contributor

@cobraz are those warnings something we should be wary of? 😅

@simenandre
Copy link
Collaborator

@cobraz are those warnings something we should be wary of? 😅

Yeah, we should probably look into that 😅

@johnkors
Copy link

Subscribe.

@lukehoban lukehoban modified the milestones: 0.79, 0.80 Nov 7, 2022
@pulumi-bot pulumi-bot added the resolution/fixed This issue was fixed label Nov 9, 2022
@RobbieMcKinstry
Copy link
Contributor

Anyone: please feel free to reopen this issue if the fix in #746 does not solve the issue for you. The next scheduled minor release is Dec 1, but I'll try to cut a release before then to release this patch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Some behavior is incorrect or out of spec resolution/fixed This issue was fixed
Projects
None yet
Development

Successfully merging a pull request may close this issue.