Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Invalid NodeJS Identifiers Generated #76

Open
rawkode opened this issue Feb 22, 2022 · 0 comments
Open

Invalid NodeJS Identifiers Generated #76

rawkode opened this issue Feb 22, 2022 · 0 comments
Labels
area/codegen Affects quality or correctness of generated code kind/bug Some behavior is incorrect or out of spec

Comments

@rawkode
Copy link

rawkode commented Feb 22, 2022

I don't know if this is in crd2pulumi specifically, or perhaps codegen of pulumi/pulumi.

To reproduce:

mkdir -p sdks/knative/v0.28.0-nodejs
curl -fsSL -o sdks/knative/v0.28.0-nodejs/crd.yaml https://doc.crds.dev/raw/github.com/knative/operator@v0.28.0
crd2pulumi --force --nodejsName knative --nodejsPath sdks/knative/v0.28.0-nodejs sdks/knative/v0.28.0-nodejs/crd.yaml

Then look inside the types/outputs.ts file and find a property on a map called ephemeral-storage?

❯ cat sdks/knative/v0.29.1-nodejs/types/output.ts| grep ephemeral
            ephemeral-storage?: string;
            ephemeral-storage?: string;
            ephemeral-storage?: string;
            ephemeral-storage?: string;
@rawkode rawkode added the kind/bug Some behavior is incorrect or out of spec label Feb 22, 2022
@mattolenik mattolenik added the area/codegen Affects quality or correctness of generated code label Jun 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/codegen Affects quality or correctness of generated code kind/bug Some behavior is incorrect or out of spec
Projects
None yet
Development

No branches or pull requests

2 participants