Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add text to inform users about ESC on creds error #2907

Merged
merged 2 commits into from Oct 30, 2023

Conversation

zchase
Copy link

@zchase zchase commented Oct 20, 2023

Part of https://github.com/pulumi/marketing/issues/816

This PR adds some text to current text emitted when a user hits a credentials to let them know about ESC and that they can configure their AWS creds with ESC. When I was testing this locally I noticed the error emitted twice (same with a warning about using the aws plugin from my path) so not sure if that is expected with local dev.

Example output:

promote-esc-on-error-aws

@zchase zchase added the impact/no-changelog-required This issue doesn't require a CHANGELOG update label Oct 20, 2023
@lukehoban
Copy link
Member

I would like to have a great page we can point to here specifically for configuring AWS OIDC + ESC. I believe that is in progress but not available yet. Suggest we hold on this till that lands, then link to that directly.

When I was testing this locally I noticed the error emitted twice

Yeah - a number of existing issues with this error message tracked in #2285.

@github-actions
Copy link

Does the PR have any schema changes?

Does the PR have any schema changes?

Looking good! No breaking changes found.
No new resources/functions.

Maintainer note: consult the runbook for dealing with any breaking changes.

@joeduffy
Copy link
Member

I would like to have a great page we can point to here specifically for configuring AWS OIDC + ESC.

Can someone link to that work item? I'd personally bank Zach's change and then revise it once the new page is available, unless it is imminent (as in <48 hours). It would be awesome if it is!

@codecov
Copy link

codecov bot commented Oct 30, 2023

Codecov Report

Merging #2907 (956a2c6) into master (ac5e135) will not change coverage.
Report is 16 commits behind head on master.
The diff coverage is n/a.

❗ Current head 956a2c6 differs from pull request most recent head d52eb54. Consider uploading reports for the commit d52eb54 to get more accurate results

@@      Coverage Diff       @@
##   master   #2907   +/-   ##
==============================
==============================

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@iwahbe
Copy link
Member

iwahbe commented Oct 30, 2023

@zchase Are you still interested in getting this change in as is?

@iwahbe iwahbe self-requested a review October 30, 2023 19:05
@zchase
Copy link
Author

zchase commented Oct 30, 2023

@iwahbe Yup! This link currently is the most up to date resource for this. Once we have "guides" in our docs we will want to update this link and apply this change to some of our other most used providers.

@iwahbe iwahbe merged commit a6ba396 into master Oct 30, 2023
16 checks passed
@iwahbe iwahbe deleted the zchase/promote-esc-on-creds-error branch October 30, 2023 19:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
impact/no-changelog-required This issue doesn't require a CHANGELOG update
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants