Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Introduce accidentally dropped Plugin Framework resources #3099

Merged
merged 7 commits into from Dec 7, 2023
Merged

Introduce accidentally dropped Plugin Framework resources #3099

merged 7 commits into from Dec 7, 2023

Conversation

t0yv0
Copy link
Member

@t0yv0 t0yv0 commented Dec 7, 2023 •
edited

Fixes #3081

An unfortunate interaction of schema manipulation over tags_all and how the upstream provider is written caused silent dropout of new PF based resources. WIth these changes make tfgen will fail loudly when this happens in the future, and the resources are now reintroduced to the provider.

5 resources in total:

`tags_all` attribute must not be Computed: aws_docdbelastic_cluster
`tags_all` attribute must not be Computed: aws_eks_pod_identity_association
`tags_all` attribute must not be Computed: aws_s3control_access_grant
`tags_all` attribute must not be Computed: aws_s3control_access_grants_instance
`tags_all` attribute must not be Computed: aws_s3control_access_grants_location

@t0yv0 t0yv0 changed the title Fix 3081: reintroduce accidentally missing Plugin Framework based resources Introduces accidentally dropped Plugin Framework resources Dec 7, 2023
@t0yv0 t0yv0 changed the title Introduces accidentally dropped Plugin Framework resources Introduce accidentally dropped Plugin Framework resources Dec 7, 2023
@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 7, 2023

Does the PR have any schema changes?

Does the PR have any schema changes?

Looking good! No breaking changes found.

New resources:

  • docdb/elasticCluster.ElasticCluster
  • eks/podIdentityAssociation.PodIdentityAssociation
  • s3control/accessGrant.AccessGrant
  • s3control/accessGrantsInstance.AccessGrantsInstance
  • s3control/accessGrantsLocation.AccessGrantsLocation

Maintainer note: consult the runbook for dealing with any breaking changes.

VenelinMartinov
VenelinMartinov approved these changes Dec 7, 2023
View reviewed changes
Copy link
Contributor

@VenelinMartinov VenelinMartinov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for sorting this out!

@t0yv0 t0yv0 merged commit e68945c into master Dec 7, 2023
18 checks passed
@t0yv0 t0yv0 deleted the t0yv0/fix-3081 branch December 7, 2023 13:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@VenelinMartinov VenelinMartinov VenelinMartinov approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Missing new resource aws_eks_pod_identity_association in 6.13.0
2 participants
@t0yv0 @VenelinMartinov