Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade terraform-provider-aws to v5.35.0 #3398

Merged
merged 6 commits into from Feb 7, 2024

Conversation

t0yv0
Copy link
Member

@t0yv0 t0yv0 commented Feb 7, 2024

This PR was generated via $ upgrade-provider pulumi/pulumi-aws --kind provider.


@t0yv0 t0yv0 added the needs-release/minor When a PR with this label merges, it initiates a release of vX.Y+1.0 label Feb 7, 2024
@t0yv0 t0yv0 self-assigned this Feb 7, 2024
@t0yv0 t0yv0 requested a review from iwahbe February 7, 2024 18:05
Copy link

github-actions bot commented Feb 7, 2024

Does the PR have any schema changes?

Does the PR have any schema changes?

Found 6 breaking changes:

Resources

  • 🟢 "aws:dms/eventSubscription:EventSubscription": required: "sourceIds" property is no longer Required

Functions

  • 🟡 "aws:bedrockfoundation/getModels:getModels": inputs: "modelSummaries" missing input "modelSummaries"

Types

  • "aws:bedrockfoundation/getModelsModelSummary:getModelsModelSummary": properties:
    • 🟡 "customizationsSupporteds": items type changed from "string" to "pulumi.json#/Any"
    • 🟡 "inferenceTypesSupporteds": items type changed from "string" to "pulumi.json#/Any"
    • 🟡 "inputModalities": items type changed from "string" to "pulumi.json#/Any"
    • 🟡 "outputModalities": items type changed from "string" to "pulumi.json#/Any"

New resources:

  • bedrock/customModel.CustomModel
  • lex/v2modelsSlot.V2modelsSlot
  • lex/v2modelsSlotType.V2modelsSlotType
  • rekognition/collection.Collection
  • sesv2/emailIdentityPolicy.EmailIdentityPolicy
  • ssm/contactsRotation.ContactsRotation

New functions:

  • bedrock/getCustomModel.getCustomModel
  • bedrock/getCustomModels.getCustomModels
  • ssm/getContactsRotation.getContactsRotation

Maintainer note: consult the runbook for dealing with any breaking changes.

@t0yv0
Copy link
Member Author

t0yv0 commented Feb 7, 2024

Filing #3399

@t0yv0
Copy link
Member Author

t0yv0 commented Feb 7, 2024

Filing #3400

@t0yv0
Copy link
Member Author

t0yv0 commented Feb 7, 2024

We can follow up with these ticket shortly but in my understanding it might not be worth blocking the upgrade on that. Recommend proceeding with the release.

@t0yv0 t0yv0 requested a review from a team February 7, 2024 19:24
Copy link
Contributor

@guineveresaenger guineveresaenger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agree the changes are non-blocking. Should #3399 be a bridge issue though?

@t0yv0
Copy link
Member Author

t0yv0 commented Feb 7, 2024

Yeah, or have a matching bridge issue. Getting there.

@t0yv0 t0yv0 merged commit 7c8b0ee into master Feb 7, 2024
19 checks passed
@t0yv0 t0yv0 deleted the upgrade-terraform-provider-aws-to-v5.35.0 branch February 7, 2024 21:23
@github-actions github-actions bot removed the needs-release/minor When a PR with this label merges, it initiates a release of vX.Y+1.0 label Feb 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Upgrade terraform-provider-aws to v5.35.0
2 participants