Revisit forceDelete usability

[t0yv0]

Hello!

• Vote on this issue by adding a 👍 reaction
• If you want to implement this feature, comment to let us know (we'll work with you on design, scheduling, etc.)

Issue details

A number of resources have forceDelete functionality that might need revisiting. In particular in Pulumi Deployments Dev Stacks scenario Pulumi needs to be able to delete resources.

Exported grep results:

sdk/nodejs/autoscaling/policy.ts:33: *     forceDelete: true,
sdk/nodejs/autoscaling/schedule.ts:24: *     forceDelete: true,
sdk/nodejs/autoscaling/group.ts:38: *     forceDelete: true,
sdk/nodejs/autoscaling/group.ts:406: *     forceDelete: true,
sdk/nodejs/autoscaling/group.ts:554:    public readonly forceDelete!: pulumi.Output<boolean | undefined>;
sdk/nodejs/autoscaling/group.ts:558:    public readonly forceDeleteWarmPool!: pulumi.Output<boolean | undefined>;
sdk/nodejs/autoscaling/group.ts:734:            resourceInputs["forceDelete"] = state ? state.forceDelete : undefined;
sdk/nodejs/autoscaling/group.ts:735:            resourceInputs["forceDeleteWarmPool"] = state ? state.forceDeleteWarmPool : undefined;
sdk/nodejs/autoscaling/group.ts:783:            resourceInputs["forceDelete"] = args ? args.forceDelete : undefined;
sdk/nodejs/autoscaling/group.ts:784:            resourceInputs["forceDeleteWarmPool"] = args ? args.forceDeleteWarmPool : undefined;
sdk/nodejs/autoscaling/group.ts:872:    forceDelete?: pulumi.Input<boolean>;
sdk/nodejs/autoscaling/group.ts:876:    forceDeleteWarmPool?: pulumi.Input<boolean>;
sdk/nodejs/autoscaling/group.ts:1076:    forceDelete?: pulumi.Input<boolean>;
sdk/nodejs/autoscaling/group.ts:1080:    forceDeleteWarmPool?: pulumi.Input<boolean>;
sdk/nodejs/redshift/endpointAuthorization.ts:79:    public readonly forceDelete!: pulumi.Output<boolean | undefined>;
sdk/nodejs/redshift/endpointAuthorization.ts:110:            resourceInputs["forceDelete"] = state ? state.forceDelete : undefined;
sdk/nodejs/redshift/endpointAuthorization.ts:124:            resourceInputs["forceDelete"] = args ? args.forceDelete : undefined;
sdk/nodejs/redshift/endpointAuthorization.ts:159:    forceDelete?: pulumi.Input<boolean>;
sdk/nodejs/redshift/endpointAuthorization.ts:189:    forceDelete?: pulumi.Input<boolean>;
sdk/nodejs/ecs/taskSet.ts:105:    public readonly forceDelete!: pulumi.Output<boolean | undefined>;
sdk/nodejs/ecs/taskSet.ts:188:            resourceInputs["forceDelete"] = state ? state.forceDelete : undefined;
sdk/nodejs/ecs/taskSet.ts:218:            resourceInputs["forceDelete"] = args ? args.forceDelete : undefined;
sdk/nodejs/ecs/taskSet.ts:264:    forceDelete?: pulumi.Input<boolean>;
sdk/nodejs/ecs/taskSet.ts:350:    forceDelete?: pulumi.Input<boolean>;
sdk/nodejs/ecr/repository.ts:78:    public readonly forceDelete!: pulumi.Output<boolean | undefined>;
sdk/nodejs/ecr/repository.ts:125:            resourceInputs["forceDelete"] = state ? state.forceDelete : undefined;
sdk/nodejs/ecr/repository.ts:136:            resourceInputs["forceDelete"] = args ? args.forceDelete : undefined;
sdk/nodejs/ecr/repository.ts:167:    forceDelete?: pulumi.Input<boolean>;
sdk/nodejs/ecr/repository.ts:212:    forceDelete?: pulumi.Input<boolean>;
sdk/nodejs/elasticbeanstalk/applicationVersion.ts:97:    public readonly forceDelete!: pulumi.Output<boolean | undefined>;
sdk/nodejs/elasticbeanstalk/applicationVersion.ts:136:            resourceInputs["forceDelete"] = state ? state.forceDelete : undefined;
sdk/nodejs/elasticbeanstalk/applicationVersion.ts:155:            resourceInputs["forceDelete"] = args ? args.forceDelete : undefined;
sdk/nodejs/elasticbeanstalk/applicationVersion.ts:190:    forceDelete?: pulumi.Input<boolean>;
sdk/nodejs/elasticbeanstalk/applicationVersion.ts:232:    forceDelete?: pulumi.Input<boolean>;
sdk/nodejs/lightsail/bucket.ts:77:     * Force Delete non-empty buckets using `pulumi destroy`. AWS by default will not delete an s3 bucket which is not empty, to prevent losing bucket data and affecting other resources in lightsail. If `forceDelete` is set to `true` the bucket will be deleted even when not empty.
sdk/nodejs/lightsail/bucket.ts:79:    public readonly forceDelete!: pulumi.Output<boolean | undefined>;
sdk/nodejs/lightsail/bucket.ts:121:            resourceInputs["forceDelete"] = state ? state.forceDelete : undefined;
sdk/nodejs/lightsail/bucket.ts:134:            resourceInputs["forceDelete"] = args ? args.forceDelete : undefined;
sdk/nodejs/lightsail/bucket.ts:171:     * Force Delete non-empty buckets using `pulumi destroy`. AWS by default will not delete an s3 bucket which is not empty, to prevent losing bucket data and affecting other resources in lightsail. If `forceDelete` is set to `true` the bucket will be deleted even when not empty.
sdk/nodejs/lightsail/bucket.ts:173:    forceDelete?: pulumi.Input<boolean>;
sdk/nodejs/lightsail/bucket.ts:208:     * Force Delete non-empty buckets using `pulumi destroy`. AWS by default will not delete an s3 bucket which is not empty, to prevent losing bucket data and affecting other resources in lightsail. If `forceDelete` is set to `true` the bucket will be deleted even when not empty.
sdk/nodejs/lightsail/bucket.ts:210:    forceDelete?: pulumi.Input<boolean>;

Affected area/feature

[t0yv0]

Kudos @AaronFriel for pointing this out.

[t0yv0]

Talking with @corymhall here we could also take a provider option to set in dev stacks that would make all forceDelete assume true.

[AaronFriel]

What's confusing to me is that it feels like what should happen here is that it fights with our resource option protect. I can:

• Set forceDelete: true, protect: true - nonsense, resource will never be deleted
• Set forceDelete: false, protect: false - nonsense, resource will fail on delete