Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Normalize rententionDays in controltower.LandingZone #3812

Merged
merged 2 commits into from Apr 15, 2024
Merged

Conversation

t0yv0
Copy link
Member

@t0yv0 t0yv0 commented Apr 12, 2024

Fix #3650

Adds a patch to rewrite LandingZone manifest JSON blobs to always perform normalization of the following kind:

- "retentionDays": "3650"
+ "retentionDays": 3650

@t0yv0 t0yv0 requested a review from corymhall April 12, 2024 20:54
@t0yv0
Copy link
Member Author

t0yv0 commented Apr 12, 2024

Per our conversation we are not likely to be able to test this resource at integration level as it requires having sub-accounts setup which our testing infra currently does not support. To test this I massaged state.json from the ticket and tried some program variations, capturing the Diff call with PULUMI_DEBUG_GRPC and testing that particular call specifically without the cloud bits.

Copy link

Does the PR have any schema changes?

Does the PR have any schema changes?

Looking good! No breaking changes found.
No new resources/functions.

Maintainer note: consult the runbook for dealing with any breaking changes.

Copy link

Is README.md missing any configuration options?

assumeRoleWithWebIdentity not found in Configuration section
customCaBundle not found in Configuration section
defaultTags not found in Configuration section
ec2MetadataServiceEndpoint not found in Configuration section
ec2MetadataServiceEndpointMode not found in Configuration section
httpProxy not found in Configuration section
httpsProxy not found in Configuration section
ignoreTags not found in Configuration section
noProxy not found in Configuration section
retryMode not found in Configuration section
s3UsEast1RegionalEndpoint not found in Configuration section
sharedConfigFiles not found in Configuration section
skipRequestingAccountId not found in Configuration section
stsRegion not found in Configuration section
tokenBucketRateLimiterCapacity not found in Configuration section
useDualstackEndpoint not found in Configuration section

Please add a description for each of these options to README.md. Details about them can be found in either the upstream docs or schema.json.

@t0yv0 t0yv0 merged commit 8f74c96 into master Apr 15, 2024
24 checks passed
@t0yv0 t0yv0 deleted the t0yv0/fix-3650 branch April 15, 2024 15:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Failed to create and update controltower.LandingZone
2 participants