Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix panic in aws.rds.Proxy #3838

Merged
merged 5 commits into from Apr 18, 2024
Merged

Fix panic in aws.rds.Proxy #3838

merged 5 commits into from Apr 18, 2024

Conversation

t0yv0
Copy link
Member

@t0yv0 t0yv0 commented Apr 17, 2024

Fixes #3835 by reverting the upstream change until the upstream issue is root-caused and resolved. Passing an empty object to auths field of aws.rds.Proxy should no longer panic.

@t0yv0 t0yv0 requested a review from corymhall April 17, 2024 20:45
Copy link

Does the PR have any schema changes?

Looking good! No breaking changes found.
No new resources/functions.

Maintainer note: consult the runbook for dealing with any breaking changes.

Copy link

Is README.md missing any configuration options?

assumeRoleWithWebIdentity not found in Configuration section
customCaBundle not found in Configuration section
defaultTags not found in Configuration section
ec2MetadataServiceEndpoint not found in Configuration section
ec2MetadataServiceEndpointMode not found in Configuration section
httpProxy not found in Configuration section
httpsProxy not found in Configuration section
ignoreTags not found in Configuration section
noProxy not found in Configuration section
retryMode not found in Configuration section
s3UsEast1RegionalEndpoint not found in Configuration section
sharedConfigFiles not found in Configuration section
skipRequestingAccountId not found in Configuration section
stsRegion not found in Configuration section
tokenBucketRateLimiterCapacity not found in Configuration section
useDualstackEndpoint not found in Configuration section

Please add a description for each of these options to README.md. Details about them can be found in either the upstream docs or schema.json.

provider/provider_nodejs_test.go Outdated Show resolved Hide resolved
provider/test-programs/regress-3835/index.ts Outdated Show resolved Hide resolved
@t0yv0
Copy link
Member Author

t0yv0 commented Apr 18, 2024

Test failures fixed on master; rebasing.

@t0yv0
Copy link
Member Author

t0yv0 commented Apr 18, 2024

/release patch

@t0yv0 t0yv0 merged commit 34e21c8 into master Apr 18, 2024
23 checks passed
@t0yv0 t0yv0 deleted the t0yv0/fix-3835 branch April 18, 2024 21:30
@github-actions github-actions bot added needs-release/patch When a PR with this label merges, it initiates a release of vX.Y.Z+1 and removed needs-release/patch When a PR with this label merges, it initiates a release of vX.Y.Z+1 labels Apr 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

rds.resourceProxy Panic
2 participants