Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Be able to declare a provider explicitly requiring a specific role #954

Closed
leezen opened this issue Apr 27, 2020 · 1 comment
Closed

Be able to declare a provider explicitly requiring a specific role #954

leezen opened this issue Apr 27, 2020 · 1 comment
Assignees
Labels
kind/enhancement Improvements or new features resolution/fixed This issue was fixed
Milestone

Comments

@leezen
Copy link
Contributor

leezen commented Apr 27, 2020

So in this case it might be worth documenting how the effects the underlining providers as well. I don't think it's an uncommon thing to want to target another role in another account via a provider in code. But I'd expect by declaring a provider saying "you must be this role" and magically bypassing seems pretty dangerous. Bearing in mind the underlying profile could be a completely different set of credentials. I'd either want a hard failure telling me this can have unexpected outcomes, or for it to always use the role I declare(whether it be by profile name or roleArn)

The reasoning is when you shift a set of code from say your laptop (configured with AWS creds) to CI (likely env vars set) the behaviour can have considerably different outcomes.

Originally posted by @zoltrain in #952 (comment)

@stack72
Copy link
Contributor

stack72 commented Jun 15, 2022

We have removed the code that stores the PROFILE in the stack as that was found to have bad consequences for teams using a profile that related to different credentials :)

@stack72 stack72 added kind/enhancement Improvements or new features resolution/fixed This issue was fixed labels Jun 15, 2022
@stack72 stack72 self-assigned this Jun 15, 2022
@stack72 stack72 added this to the 0.74 milestone Jun 15, 2022
@stack72 stack72 closed this as completed Jun 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement Improvements or new features resolution/fixed This issue was fixed
Projects
None yet
Development

No branches or pull requests

2 participants