-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
Specify custom API version on resources #2467
Labels
area/providers
impact/accessibility
Something that is difficult or impossible for some people to use
impact/regression
Something that used to work, but is now broken
kind/enhancement
Improvements or new features
size/M
Estimated effort to complete (up to 5 days).
Comments
danielrbradley
added
kind/enhancement
Improvements or new features
size/M
Estimated effort to complete (up to 5 days).
impact/accessibility
Something that is difficult or impossible for some people to use
area/providers
labels
May 24, 2023
resolves #1877 |
thomas11
added
the
impact/regression
Something that used to work, but is now broken
label
Aug 18, 2023
@danielrbradley the "resource doesn't exist in the SDK" case is covered by #68. Whereas #1877 is explicitly about API versions - although the semantics of the use case may differ. We should clarify this. |
@thomas11 ah yes your right - custom resource providers meaning API versions we don't support. |
Discussion points with @mikhailshilkov
|
This was referenced Aug 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
area/providers
impact/accessibility
Something that is difficult or impossible for some people to use
impact/regression
Something that used to work, but is now broken
kind/enhancement
Improvements or new features
size/M
Estimated effort to complete (up to 5 days).
Hello!
Issue details
In version 2 of the provider we're removing selected resources to reduce SDK size where the next version of the resource is compatible with the previous verion. In theory API behaviour can vary between versions and a user might want to use a specific version.
To ensure that the provider allows a user to interact with the full Azure surface area, we could add a string
ApiVersion
field to all resources which would allow the same SDK class to be used with other versions.Initially this could be just a string field but could also be implemented to include an enum of known versions for that resource.
If the user specifies an invalid API version or a version that's incompatible with the resources shape of the SDK resource class then errors would just be propegated by the Azure API - we would not validate this. We could also consider disabling validation of properties if the version is specified in case transformations are also being used to manipulate the shape of the payload.
Affected area/feature
Use cases
The text was updated successfully, but these errors were encountered: