Support static file assets. #23
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Static file assets--that is, file assets that are not generated by running a command--are translated to S3 bucket object resources. As part of these changes, a new node is created in the resource tree that corresponds to the CDK stack itself in order to simplify the dependency graph. This node depends on any assets required by the stack (rather than plumbing the assets through to each of the stack's children).
|
With these changes, the s3-object-lambda test should pass. |
|
As it turns out, this is blocked on an AWS Native bug: pulumi/pulumi-aws-native#466 |
Just to clarify: the test that I was hoping to enable is blocked on a release with that bug fix, but the code changes here are not. |
v0.16.0 has just been released. |
viveklak
approved these changes
Apr 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Static file assets--that is, file assets that are not generated by
running a command--are translated to S3 bucket object resources. As part
of these changes, a new node is created in the resource tree that
corresponds to the CDK stack itself in order to simplify the dependency
graph. This node depends on any assets required by the stack (rather
than plumbing the assets through to each of the stack's children).