Draft: adjust public API #31
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Note that I've opened this as a draft for discussion. |
viveklak
approved these changes
Apr 29, 2022
|
cc @eladb for visibility |
The proposed public API requires that users subclass pulumicdk.Stack (which is itself a subclass of cdk.Stack) and call `this.synth()` at the end of the subclass's constructor. `synth` is provided by `pulumicdk.Stack` and does the work of creating a Pulumi component resource, synthesizing the CDK resources, etc.
pgavlin
force-pushed
the
pgavlin/stack-api
branch
from
2116273
to
c117e73
Compare
eladb
reviewed
May 2, 2022
| new CfnOutput(this, 'url', { value: service.serviceUrl }); | ||
| this.url = this.asOutput(service.serviceUrl); | ||
|
|
||
| this.synth(); | ||
| } | ||
| } | ||
|
|
||
| const stack = new pulumicdk.Stack('teststack', AppRunnerStack); |
There was a problem hiding this comment.
I expected this to be new AppRunnerStack('teststack'), no?
eladb
reviewed
May 2, 2022
| new CfnOutput(this, 'url', { value: service.serviceUrl }); | ||
| this.url = this.asOutput(service.serviceUrl); | ||
|
|
||
| this.synth(); |
There was a problem hiding this comment.
Is there a way to at least discover that the stack was not synthesized and emit an error?
eladb
reviewed
May 2, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The proposed public API requires that users subclass pulumicdk.Stack
(which is itself a subclass of cdk.Stack) and call
this.synth()at theend of the subclass's constructor.
synthis provided bypulumicdk.Stackand does the work of creating a Pulumi componentresource, synthesizing the CDK resources, etc.