Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make it possible to keep container logs around for longer than a day #519

Closed
mmdriley opened this issue Jun 22, 2018 · 0 comments
Closed
Assignees
Labels
kind/design An engineering design doc, usually part of an Epic kind/enhancement Improvements or new features resolution/wont-fix This issue won't be fixed

Comments

@mmdriley
Copy link
Contributor

The log group we create for a cloud.Service in AWS always has a retention of 1 day:

pulumi-cloud/aws/service.ts

Lines 451 to 454 in 9c81b0b

// Create a single log group for all logging associated with the Service
const logGroup = new aws.cloudwatch.LogGroup(name, {
retentionInDays: 1,
}, { parent: parent });

We chose a small value because these logs were also diverted to a log collector lambda:

pulumi-cloud/aws/service.ts

Lines 443 to 448 in dd812cb

// And hook it up to the aggregated log collector
const subscriptionFilter = new aws.cloudwatch.LogSubscriptionFilter(name, {
logGroup: logGroup,
destinationArn: getLogCollector().arn,
filterPattern: "",
}, { parent: parent });

But we removed that in #474.

@mmdriley mmdriley changed the title Make it possible to keep container logs around Make it possible to keep container logs around for longer than a day Jun 22, 2018
@joeduffy joeduffy added kind/feature kind/design An engineering design doc, usually part of an Epic labels Jun 30, 2018
@infin8x infin8x added kind/enhancement Improvements or new features and removed kind/feature labels Jul 10, 2021
@mjeffryes mjeffryes added the resolution/wont-fix This issue won't be fixed label Jun 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/design An engineering design doc, usually part of an Epic kind/enhancement Improvements or new features resolution/wont-fix This issue won't be fixed
Projects
None yet
Development

No branches or pull requests

5 participants