Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WAF Ruleset update on every run #630

Open
gleb-jiji opened this issue Jan 23, 2024 · 1 comment
Open

WAF Ruleset update on every run #630

gleb-jiji opened this issue Jan 23, 2024 · 1 comment
Labels
bug/diff kind/bug related to Pulumi generating wrong diffs on preview or up. kind/bug Some behavior is incorrect or out of spec

Comments

@gleb-jiji
Copy link

What happened?

WAF Ruleset is being updated on every run without any visible changes, similarly to #444. Seems to be triggered by rules that use action_parameters.

Example

from pulumi_cloudflare import Ruleset, RulesetRuleArgs, RulesetRuleActionParametersArgs

Ruleset(
    "waf",
    zone_id=zone_id,
    name="Custom WAF",
    phase="http_request_firewall_custom",
    kind="zone",
    rules=[
        RulesetRuleArgs(
            description="Test",
            expression='true',
            enabled=False,
            action="skip",
            action_parameters=RulesetRuleActionParametersArgs(
                phases=["http_request_firewall_managed"],
                products=["securityLevel"],
                ruleset="current",
            ),
        ),
    ],
)

Output of pulumi about

CLI          
Version      3.101.1
Go Version   go1.21.5
Go Compiler  gc

Plugins
NAME          VERSION
aws           6.18.0
cloudflare    5.18.1
digitalocean  4.25.1
hcloud        1.16.2
proxmoxve     5.21.0
python        unknown
random        4.15.0

Host     
OS       fedora
Version  38
Arch     x86_64

This project is written in python: executable='/home/user/.cache/pypoetry/virtualenvs/infra-PmXxtYjb-py3.11/bin/python3' version='3.11.7'

...

Dependencies:
NAME                 VERSION
cloudflare           2.16.0
pip                  23.2.1
pulumi_aws           6.18.0
pulumi_cloudflare    5.18.1
pulumi_digitalocean  4.25.1
pulumi-hcloud        1.16.2
pulumi_proxmoxve     5.21.0
pulumi-random        4.15.0
setuptools           68.0.0
wheel                0.41.0

Additional context

No response

Contributing

Vote on this issue by adding a 👍 reaction.
To contribute a fix for this issue, leave a comment (and link to your pull request, if you've opened one already).

@gleb-jiji gleb-jiji added kind/bug Some behavior is incorrect or out of spec needs-triage Needs attention from the triage team labels Jan 23, 2024
@iwahbe iwahbe added bug/diff kind/bug related to Pulumi generating wrong diffs on preview or up. and removed needs-triage Needs attention from the triage team labels Jan 25, 2024
@iwahbe
Copy link
Member

iwahbe commented Jan 25, 2024

Hi @gleb-jiji. Thanks for opening a new issue and posting a reproduction.

CC @t0yv0 I believe you were interested here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug/diff kind/bug related to Pulumi generating wrong diffs on preview or up. kind/bug Some behavior is incorrect or out of spec
Projects
None yet
Development

No branches or pull requests

2 participants