Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

preview should catch if TTL is set to != 1 and record is protected or proxied #669

Open
o-l-a-v opened this issue Mar 1, 2024 · 2 comments
Open

preview should catch if TTL is set to != 1 and record is protected or proxied #669

o-l-a-v opened this issue Mar 1, 2024 · 2 comments
Labels
awaiting-upstream Awaiting upstream dependency kind/enhancement Improvements or new features

Comments

@o-l-a-v
Copy link

o-l-a-v commented Mar 1, 2024 •
edited

Hello!

  • Vote on this issue by adding a 馃憤 reaction
  • If you want to implement this feature, comment to let us know (we'll work with you on design, scheduling, etc.)

Issue details

Pulumi preview goes through for records where TTL is set to anything but 1 (1 = Use Cloudflare default), and record is either proxied or protected, while this will fail at deploy.

cloudflare:index:Record (<redacted>):
error: 1 error occurred:
  * updating <redacted>: 1 error occurred:
  * error validating record test: ttl must be set to 1 when `proxied` is true

Affected area/feature

Pulumi preview should catch this.
@o-l-a-v o-l-a-v added kind/enhancement Improvements or new features needs-triage Needs attention from the triage team labels Mar 1, 2024
@iwahbe iwahbe removed the needs-triage Needs attention from the triage team label Mar 4, 2024
@iwahbe
Copy link
Member

iwahbe commented Mar 4, 2024

Hi @o-l-a-v. Thanks for the suggestion.

Just to clarify: When you say pulumi plan, you mean pulumi preview? Right?

@iwahbe iwahbe added the awaiting-upstream Awaiting upstream dependency label Mar 4, 2024
@o-l-a-v
Copy link
Author

o-l-a-v commented Mar 4, 2024

Hi @iwahbe. Oops, yes, preview.

@o-l-a-v o-l-a-v changed the title plan should catch if TTL is set to != 1 and record is protected or proxied preview should catch if TTL is set to != 1 and record is protected or proxied Mar 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
awaiting-upstream Awaiting upstream dependency kind/enhancement Improvements or new features
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@o-l-a-v @iwahbe